bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Confirm Resolution text says Undefined while filing for a VD. #15856

Open riyazuddinsyed opened 1 year ago

riyazuddinsyed commented 1 year ago

Describe the bug in the current situation When filing for a VD in Step 2 the label under "Confirm Resolution Completion" says undefined in the label text

Impact of this bug Users filing for VD.

Steps to reproduce the behavior:

  1. Login with BCREGA001
  2. Open the filing "https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/dissolution-resolution?id=BC0871281&accountid=2079"
  3. Go to the Complete Resolution step
  4. Under step 2 notice the Label text says filed by " Undefined"

Screenshots/ Visual Reference/ Source Screen Shot 2023-04-03 at 9.13.06 PM.png

severinbeauvais commented 1 year ago

The cause of this bug is that the Legal Name is supposed to be displayed there, but this is actually a numbered company. There should be a fallback for legal name in this case.

Another symptom of this is that the Entity Info Header displays the business name as "Numbered Benefit Company" instead of the actual numbered name (xxxx BC LTD).

It's possible that, in the case of a dissolution, legal name in the store needs to be set (which doesn't apply to IAs or regs because for them the numbered name is not known yet).