Edit UI: proprietor missing middle name in correction

[severinbeauvais]

1. login as staff
2. open sample business: https://dev.business.bcregistry.gov.bc.ca/FM1001317?accountid=2288
3. observe that proprietor has a middle initial, ie.

4. start or resume a correction filing
5. observe that proprietor does not have a middle name, ie.

[severinbeauvais]

Note for developer: I have verified that the middle name comes across in the API call (parties[].officer) but he UI is not displaying it (and it's not present if I edit/correct the director, either).

[hardikbcreg]

During my testing and repro I found out that this is no more the case as per below :

[hardikbcreg]

Observed the same name for Proprietor. Testing now the correction action to make sure this bug is resolved.

[severinbeauvais]

It still doesn't work for me.

Try logging in as staff and opening the following: https://dev.edit.business.bcregistry.gov.bc.ca/FM1001317/correction/?correction-id=144716&accountid=3040

[hardikbcreg]

Hi @severinbeauvais , I tried logging in with my IDIR (not sure if it's same as login as staff) and clicked the above given link, this is what is shows :

[hardikbcreg]

https://images.zenhubusercontent.com/157936592/4952d22d-c805-4b98-bf8c-47b7ed0a72ed/screen_recording_2023_04_27_at_6_13_11_pm.mov

[severinbeauvais]

~Sorry, I accidentally filed that Special Resolution.~

~Just create another Special Resolution on the same business and have a look.~

[hardikbcreg]

Hi @severinbeauvais , I am newbie here so don't know what's the special resolution. I tried this : https://images.zenhubusercontent.com/157936592/ffe88a15-2d86-4e47-b92c-e1bc13a6db47/screen_recording_2023_04_28_at_9_36_41_am.mov

[severinbeauvais]

Whoops, I had my wires crossed. Yes, it's a correction you want to do.

The steps you took in your latest recording above look correct. In fact, I tried the exact same thing and I was able to get into the correction filing. I assume your login is missing a permissions to allow you to enter a correction.

Once you get into a correction filing, you'll want to run Edit UI locally (npm run serve) and then point your browser to the local instance. The URL will look something like this (with a different correction id): http://localhost:8080/FM1001317/correction/?correction-id=144759&accountid=3040

Then you can reproduce the error, trace through the code, set breakpoints, etc.

[steveburtch]

@severinbeauvais who should we ask to get Hardik the permission to allow him to enter the correction? @hardikbcreg

[severinbeauvais]

@severinbeauvais who should we ask to get Hardik the permission to allow him to enter the correction? @hardikbcreg

The same person who set up his IDIR for use in BCROS systems.

[steveburtch]

K, thx, we'll get that request in.

[hardikbcreg]

@seeker25 is this something you can grant me additional permissions on my idir?

[hardikbcreg]

@argush3 / @vysakh-menon I see this issue is happening because the legal API returns the middleName as middleInitial field. Can you change the field to middleName in legal API to make it uniform?

[seeker25]

There would be quite a few places we'd need to change it in - not sure if that would be so easy to do

EG. AUTH-API - reports - etc.

https://github.com/bcgov/sbc-auth/blob/d02df5bf5e3d5f3dd4c9549d114e769c694a34fe/auth-api/src/auth_api/services/affiliation.py#L458

[argush3]

yes, this is something that has been talked about for awhile...fixing this issue. But as Travis pointed out, probably not something easily done as it will require code changes in multiple repos as well as updating all the existing data.

[severinbeauvais]

1. What if the API provided both the middle name and middle initial?
2. What does the API expect back: middle name or middle initial? That's what we should call it ultimately.
3. Maybe the UI should save both middle name and middle initial in the JSON?

[hardikbcreg]

Discussed this ticket in our gooming meeting and as directed by Steve (PM), nothing much we can do for now until the backend API fixes this so unassigned myself. Feel free to put it back to Business ownership (after talking with Steve) if we should apply the Frontend fix meanwhile (like checking both middlename and middleinitial fields)

[severinbeauvais]

@davemck513 What do you think we should do -- Prioritize a proper BE fix? Work around it with a quick UI + BE fix as above (1 and 3)? Give it back to Business team or have Entities team work on it?

cc @thorwolpert Thoughts?