bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Edit UI: Conversion to Full Restoration application triggers the Approval Type error. #16079

Closed riyazuddinsyed closed 4 days ago

riyazuddinsyed commented 1 year ago

Describe the bug in the current situation When the staff loads the Full Restoration Application then the filling triggers the approval type component error by selecting the Restoration Approved by a registrar check box.

Steps to reproduce the behavior:

  1. Go to 'https://dev.edit.business.bcregistry.gov.bc.ca/BC0871238/limitedRestorationToFull?restoration-id=144628&accountid=3040'
  2. Click and Open the Limited Restoration to Full filing
  3. Notice the Approval Type error triggered.

Screenshots/ Visual Reference/ Source IScreen Shot 2023-04-23 at 11.44.07 PM.png

Issue 2: There is no spacing between the "This Restoration is Approved by the Registrar" and the "Enter the Date of Notice of Application ...".

severinbeauvais commented 1 week ago

This ticket got a lot more complicated than expected because there were many things broken with the subject component (ApprovalType.vue) and its parent components. For example, the approval type, application date and notice dates were not being saved or restored. And this affected their validation, which is what I'm still working on. Per Vikas' suggestion, I've updated the estimate on this ticket to match its actual complexity/time.

severinbeauvais commented 1 week ago

Test Notes

1. Conversion to Full Restoration. Initial approval type was Court Order. No court order number entered - initial state:

image.png

2. Conversion to Full Restoration. Initial approval type was Court Order. No court order number entered - after clicking Review and Certify:

image.png

3. Conversion to Full Restoration. Initial approval type was Registrar. Registrar selected. No dates entered - initial state:

image.png

4. Conversion to Full Restoration. Initial approval type was Registrar. Registrar selected. No dates entered - after clicking Review and Certify:

image.png

5. Conversion to Full Restoration. Initial approval type was Registrar. Court order selected. No court order number entered - initial state:

image.png

6. Conversion to Full Restoration. Initial approval type was Registrar. Court order selected. No court order number entered - after clicking Review and Certify:

image.png

7. Also need to test with valid approval data to verify that Review and Certify works.

8. Also need to test "save and resume later" to verify that approval data is restored.

severinbeauvais commented 1 week ago

More Test Notes

1. Limited Restoration Extension. Initial approval type was Court Order. No court order number entered - initial state:

image.png

2. Limited Restoration Extension. Initial approval type was Court Order. No court order number entered - after clicking Review and Certify:

image.png

3. Limited Restoration Extension. Initial approval type was Registrar. (No Approval Type component.)

image.png

4. Also need to test with valid approval data to verify that Review and Certify works.

5. Also need to test save and resume later to verify that approval data is restored.