Transaction history before 2018 needed

oanyahuru commented 1 year ago

Detailed transaction histories are currently hosted in the legacy app (COBRS). It would be very helpful to have details from before 2018 moved over to the new platform since staff work based on precedence. There is some history in NameX but not in NR. Having transaction details also helps in appeals, currently staff use COBRS to verify and determine the NR approval details.

pwei1018 commented 1 year ago

Confirm with Daivd R. to see how many records in COBRS first.

eve-git commented 11 months ago

emailed David R.: Hi David, It was requested to move NR transaction history details from COBRS to new platform. Could you check how many records in COBRS? Thanks Eve

droberts27 commented 10 months ago

@pwei1018 @eve-git @oanyahuru Here are the counts older than 2018, not including 2018: Looking at cobrpdb.request I see 944,014 rows, each with a distinct NR Looking at cobrpdb.reqname I see 2,090,951 rows, each corresponding to a REQUEST row and having a choice of 1, 2, or 3

PCC199 commented 10 months ago

@oanyahuru To determine business rationale for obtaining data.

oanyahuru commented 10 months ago

The examiners have confirmed that they need the historical data, all of it. The ability to see what someone did a few years ago is very helpful and a lot of their work is based on history. It was suggested that the data could be moved and captured outside NameX, examiners can access the info when needed.

ozamani9gh commented 8 months ago

@oanyahuru there is an ops ticket that also needs historical data for it to be fixed, lower priority but a nice to have.

https://app.zenhub.com/workspaces/ops-60f8556e05d25b0011468870/issues/gh/bcgov-registries/ops-support/1447.

perhaps we can discuss next week with Joshua

oanyahuru commented 8 months ago

Sent on 9th Sept 2023

Hi David & Siddharth,

Names team had this request https://github.com/bcgov/entity/issues/16316 . We want to import the data into our Namex database. Can you please help dump the data from cobrpdb to Andrew? He can import them to Namex database.

David,

How can we give access to Andrew to see R:\ARCS\Info-Tech 6000-6999\Info System Dev and Changes 6450\80 IT application system documentation final versions\Regi Support Docs\Developers.xlsx ? Should I submit the request to IT ops?

Thanks,

Patrick Wei SRE Lead– BC Registries and Online Services Service BC Ministry of Citizens’ Services T: 778 698-1266 | Web: http://www.servicebc.gov.bc.ca “Access to government services made easy”

droberts27 commented 8 months ago

sent the following email to John McColl, Mel, Oge, and Andriy:

Hello Andriy – Is it OK if I give you this data in a format where each column starts and end with a circumflex (^). Like a CSV file (comma separated values) except the C stand for circumflex. 😊

Hi John – There are two tables cobrsdb.request and cobrsdb.reqname. I may need some help spooling my SQL output to a datafile.

droberts27 commented 7 months ago

I have given the REQNAME SQL query to John McColl and he will create the file and copy it to the Virtual Unix Box and then copy from there to Nettle. Andriy will get it from Nettle. Next we will do the REQUEST table.

droberts27 commented 7 months ago

John McColl has extracted the 2017 requests and reqnames for Andriy. If he approves we will extract the rest of the data.

bolyachevets commented 7 months ago

@oanyahuru as David mentioned in the comment above, he sent me 2017 data. I added the 2 tables in namex dev database. The table names are cobrs_reqname and cobrs_request. When the full dataset is available, I will load it up in prod. I am not sure I will be working on actual data being pulled into the namex app, and don't know if it is the ultimate plan.

bolyachevets commented 6 months ago

@oanyahuru the 2 tables (cobrs_reqname and cobrs_request) in prod namex-db contain data for 2012-2017. i believe someone from Names teams will need to write a script to populate this data in the existing data models in namex db

ozamani9gh commented 6 months ago

This is a more recent ticket related to https://app.zenhub.com/workspaces/names-team-space-65133ae62fc06d1008f59331/issues/gh/bcgov/entity/8828

droberts27 commented 6 months ago

John McColl has provided Andriy with all the REQUEST and REQNAME data older than 2018.

eve-git commented 5 months ago

@bolyachevets Looks like the NRs in cobrs_requname and cobrs_request (DEV) have already in PROD. The transaction histories are not. Could you find the transaction history data and import them in DEV or some where?

bolyachevets commented 5 months ago

@bolyachevets Looks like the NRs in cobrs_requname and cobrs_request (DEV) have already in PROD. The transaction histories are not. Could you find the transaction history data and import them in DEV or some where?

@eve-git i just loaded data that David sent to me. If this is wrong data, maybe need to explain to David what is needed so that he can sent the right tables.

bolyachevets commented 5 months ago

@eve-git If it helps, I found COBRS db design diagram (it does not look like there are other tables that can be of use to provide history data) :

Also, if you look at cobrs_request table it does contain comments (not sure if these qualify for history):

NR 0269356 | A | 2 | 2 | 2012-11-21 | 12:20:21 | PC64764 | | 2012-11-27 | 11:37:55 | PT86543 | 2012-11-27 | 09:51:10 | 0 | 62986 1 | | | P | FR | N | | SPEEDY SEARCH AND REGISTRY | | | | | |
| 1 | -1 | NR8804334 WAS APPROVED. HOWEVER, NOW WE REGISTERING DBA WITH BC CORPORATION. | | 20130122 | FM 0596304 |
| | | N | | | N NR 0269482 | A | 2 | 2 | 2012-07-12 | 14:09:47 | ANON | | 2012-07-12 | 14:09:47 | PT86543 | 2012-07-17 | 09:42:52 | 0 |
0 | | | P | SO | N | | Anthony He | | | | | |
| 3 | -1 | NON-PROFIT ORGANIZATION.OPERATED PRIMARILY BY UNPAID VOLUNTEERS | | 20121030 | |

eve-git commented 5 months ago

@droberts27 The NRs are in PROD. But we don't have transaction histories to display. Could you please export the transaction histories for the NRs?

eve-git commented 5 months ago

@bolyachevets in namex, comments are in comments table, transaction histories are in events table. In UI, transaction histories are from the little square after NR number. Comments locates below the NR nubmer:

bolyachevets commented 5 months ago

@eve-git

It might be that COBRS does not have an equivalent of events table. REQUEST table contains some info that was split in NAMEX into separate tables (e.g. comments). But REQUEST does contain some info like UPDATEDA (date record was updated), so it might be able to piece together some "history".

eve-git commented 5 months ago

@bolyachevets I see. I will see if I can make some simple 'history' from cobrs_request. Thank you!

eve-git commented 4 months ago

There are 41771 SP requests with corp_num in cobrs_request. I checked 300 of them in PROD. Their states are EXPIRED instead of CONSUMED. It looks on purpose since LTD requests do not have such issue.

eve-git commented 4 months ago

Hi Oge,

I added sample historical transactions for a few NRs before 2018 in the PROD for business verification: 'NR 0268996' -- Approved 'NR 0269610' -- Rejected 'NR 1732966' -- AL 'NR 5672355' -- AL xprov Could you check with business if they are good with the results?

I excluded consumed transactions for two reasons:

There are 41,771 SP requests with corp_num in cobrs_request. After checking 300 in PROD, I found their states as EXPIRED instead of CONSUMED, seemingly intentional for LTD requests.
Consumed transaction history is "update from nro" and marked as "system transactions."

For NRs before 2018, there are existing 'histories' resembling batch job records, showing NR states on specific days. I fixed data for two of them, visible by selecting "show system transactions": 'NR 9894392' -- AS 'NR 9789288' -- AS xprov I wonder if I will continue to ‘fix’ them or remove them for less confusing? Also, it seems not all those transactions show up after I inserted new historical records (see the four NRs above). The reason is unknown and probably some coding issues.

I will hold off on implementing on all the NRs until I receive feedback from the business.

Thanks,

eve-git commented 4 months ago

Basic transactions have been added to Namex. However, some historical data doesn't match the current information, causing potential confusion in transaction records. For example, there are two 'CANCELLED' status records. The first one on 2012-11-15 signifies a state change in Cobrs, while the 2018-10-02 entry indicates the NR import date from Cobrs. Please note that the Transaction Type is generated after the request post action—don't let it cause confusion.

eve-git commented 4 months ago

executed the following scripts to import events from cobrs (registry-staff is imported from namesp. The table will be removed from postgresql after the ticket is done.): https://github.com/bcgov-registries/ops-support/blob/main/support/ops/datafix/16316-pl-sql.sql https://github.com/bcgov-registries/ops-support/blob/main/support/ops/datafix/16316-pl-sql-find-idir-user.sql https://github.com/bcgov-registries/ops-support/blob/main/support/ops/datafix/16316-pl-sql-fix-event-json.sql

eve-git commented 4 months ago

there are 4 request states from cobrs: A - Approved C- Cancelled X - Hold R - Rejected

I will pull 25 records from cobrs per states for testing.

eve-git commented 4 months ago

-- state = 'A'

select rquestno as nr_num, reqstats as request_state, rqsttype as request_type, entrydat as create_date, entrytim as create_time, examinda as examination_date, examinti as examination_time, examinid examiner_id 
from cobrs_request
where reqstats = 'A' limit 25;
"nr_num"    "request_state" "request_type"  "create_date"   "create_time"   "examination_date"  "examination_time"  "examiner_id"
"NR 3043091"    "A" "FR"    "2012-01-02"    "12:25:14"  "2012-01-05"    "07:58:20"  "PT86543"
"NR 3043188"    "A" "CR"    "2012-09-10"    "21:09:32"  "2012-09-13"    "14:50:32"  "PH91196"
"NR 3043402"    "A" "FR"    "2012-03-26"    "15:07:25"  "2012-03-29"    "16:28:34"  "PT86543"
"NR 3043568"    "A" "CR"    "2012-03-28"    "10:54:32"  "2012-04-02"    "08:58:58"  "PT81928"
"NR 3043706"    "A" "CR"    "2012-02-21"    "10:36:34"  "2012-02-21"    "10:38:48"  "PT86543"
"NR 3043755"    "A" "FR"    "2012-11-08"    "08:23:45"  "2012-11-14"    "09:10:06"  "PT81928"
"NR 3043948"    "A" "FR"    "2012-01-27"    "13:48:16"  "2012-02-01"    "09:37:35"  "PB75075"
"NR 3044003"    "A" "FR"    "2012-11-22"    "11:19:45"  "2012-11-28"    "09:34:50"  "PA75075"
"NR 3044032"    "A" "CR"    "2012-09-20"    "12:11:53"  "2012-09-25"    "07:50:09"  "PT86543"
"NR 3044313"    "A" "CR"    "2012-11-16"    "13:04:36"  "2012-11-22"    "10:55:06"  "PT86543"
"NR 3044783"    "A" "FR"    "2012-04-04"    "12:10:06"  "2012-04-06"    "12:53:16"  "PH91196"
"NR 3044789"    "A" "CR"    "2012-09-06"    "11:38:16"  "2012-09-12"    "10:52:52"  "PT86543"
"NR 3044871"    "A" "FR"    "2012-10-01"    "09:15:20"  "2012-10-02"    "13:52:08"  "PA63374"
"NR 3044893"    "A" "FR"    "2012-08-31"    "11:35:35"  "2012-09-11"    "08:39:32"  "PA63374"
"NR 3045061"    "A" "FR"    "2012-11-07"    "16:38:20"  "2012-11-13"    "14:59:00"  "PA75075"
"NR 3045165"    "A" "CR"    "2012-07-16"    "08:22:50"  "2012-07-18"    "09:59:07"  "PH91196"
"NR 3045172"    "A" "CR"    "2012-08-27"    "12:55:37"  "2012-09-04"    "09:15:28"  "PA63374"
"NR 3045242"    "A" "FR"    "2012-09-04"    "13:04:03"  "2012-09-11"    "11:16:13"  "PT86543"
"NR 3045297"    "A" "FR"    "2012-04-26"    "09:38:11"  "2012-05-02"    "08:56:25"  "PA63374"
"NR 3045310"    "A" "CR"    "2012-05-01"    "12:58:26"  "2012-05-07"    "12:51:02"  "PT86543"
"NR 3045313"    "A" "FR"    "2012-08-29"    "10:30:30"  "2012-09-07"    "14:24:30"  "PT86543"
"NR 3045422"    "A" "FR"    "2012-10-18"    "15:29:24"  "2012-11-06"    "09:48:27"  "PT86543"
"NR 3045706"    "A" "CR"    "2012-11-08"    "14:42:19"  "2012-11-14"    "12:31:54"  "PT86543"
"NR 3045725"    "A" "CR"    "2012-06-08"    "14:33:24"  "2012-06-12"    "15:38:27"  "PT86543"
"NR 3046021"    "A" "LL"    "2012-03-02"    "11:52:03"  "2012-03-02"    "12:11:19"  "PT86543"

eve-git commented 4 months ago

"nr_num"    "request_state" "request_type"  "create_date"   "create_time"   "examination_date"  "examination_time"  "examiner_id"
"NR 3046355"    "C" "CR"    "2012-11-16"    "10:12:42"  "2012-11-16"    "10:12:42"  
"NR 3053204"    "C" "SO"    "2012-04-25"    "11:03:22"  "2012-05-01"    "09:54:44"  "PH91196"
"NR 3065629"    "C" "FR"    "2012-11-13"    "17:09:02"  "2012-11-13"    "17:09:02"  
"NR 3077841"    "C" "CR"    "2012-08-09"    "14:43:08"  "2012-08-16"    "08:35:15"  "PH91196"
"NR 3091289"    "C" "CR"    "2012-09-11"    "12:07:33"  "2012-09-11"    "12:07:33"  
"NR 3104366"    "C" "FR"    "2012-07-04"    "14:50:47"  "2012-07-09"    "13:58:08"  "PH91196"
"NR 3107372"    "C" "SO"    "2012-10-10"    "15:06:22"  "2012-10-12"    "09:11:39"  "PA63374"
"NR 3110948"    "C" "CR"    "2012-04-19"    "13:32:32"  "2012-04-25"    "10:11:44"  "PT86543"
"NR 3111373"    "C" "CR"    "2012-09-26"    "13:08:21"  "2012-09-26"    "13:08:21"  
"NR 3116225"    "C" "CR"    "2012-04-02"    "08:03:33"  "2012-04-05"    "07:54:19"  "PT86543"
"NR 3121410"    "C" "CR"    "2012-12-02"    "13:48:37"  "2012-12-02"    "13:48:37"  
"NR 3123620"    "C" "CR"    "2012-04-04"    "10:46:35"  "2012-04-04"    "10:46:35"  
"NR 3126002"    "C" "CR"    "2012-08-08"    "09:28:52"  "2012-08-14"    "09:35:01"  "PT86543"
"NR 3130780"    "C" "CR"    "2012-03-05"    "19:54:25"  "2012-03-08"    "11:41:28"  "PT86543"
"NR 3136661"    "C" "CR"    "2012-11-13"    "06:08:33"  "2012-11-16"    "16:04:37"  "PT86543"
"NR 3137524"    "C" "FR"    "2012-11-17"    "07:52:03"  "2012-11-17"    "07:52:03"  
"NR 3139604"    "C" "CR"    "2012-03-21"    "13:23:18"  "2012-03-21"    "13:23:18"  
"NR 3141445"    "C" "CR"    "2012-03-19"    "14:53:24"  "2012-03-22"    "11:42:26"  "PT86543"
"NR 3151902"    "C" "CR"    "2012-04-12"    "08:34:29"  "2012-04-12"    "08:34:29"  
"NR 3159827"    "C" "CR"    "2012-08-14"    "13:05:18"  "2012-08-14"    "13:29:01"  "PA63374"
"NR 3172575"    "C" "CR"    "2012-04-10"    "15:18:34"  "2012-04-12"    "13:53:17"  "PH91196"
"NR 3192275"    "C" "FR"    "2012-04-24"    "10:28:03"  "2012-04-24"    "10:28:03"  
"NR 3192482"    "C" "CR"    "2012-05-28"    "09:20:54"  "2012-06-01"    "16:18:36"  "PT86543"
"NR 3197824"    "C" "CR"    "2012-06-29"    "14:38:17"  "2012-06-29"    "14:39:01"  "PT86543"
"NR 3217256"    "C" "CR"    "2012-05-03"    "16:06:55"  "2012-05-03"    "16:06:55"

eve-git commented 4 months ago

Only one record on state = 'X'. No transaction show in the UI. There are 962 event records for this NR!! Please hold on test till the code fix deployed to PROD.

"nr_num"    "request_state" "request_type"  "create_date"   "create_time"   "examination_date"  "examination_time"  "examiner_id"
"NR 8411086"    "X" "CR"    "2009-11-06"    "15:35:29"  "2019-09-18"    "10:29:56"  "PA81928"

eve-git commented 4 months ago

"nr_num"    "request_state" "request_type"  "create_date"   "create_time"   "examination_date"  "examination_time"  "examiner_id"
"NR 3173142"    "R" "CR"    "2012-04-07"    "11:46:04"  "2012-04-10"    "14:40:18"  "PH91196"
"NR 3173147"    "R" "CR"    "2012-02-13"    "13:13:54"  "2012-02-14"    "16:01:26"  "PB75075"
"NR 3173997"    "R" "FR"    "2012-04-25"    "13:54:26"  "2012-05-01"    "12:41:27"  "PT86543"
"NR 3176388"    "R" "SO"    "2012-04-04"    "15:45:01"  "2012-04-06"    "13:30:12"  "PT86543"
"NR 3178775"    "R" "CR"    "2012-12-10"    "19:17:25"  "2012-12-18"    "10:57:25"  "PA75075"
"NR 3180459"    "R" "CR"    "2012-07-11"    "18:38:57"  "2012-07-17"    "08:15:56"  "PT86543"
"NR 3181109"    "R" "CR"    "2012-05-23"    "11:14:40"  "2012-05-28"    "13:56:25"  "PA63374"
"NR 3181330"    "R" "SO"    "2012-12-01"    "21:21:36"  "2012-12-07"    "10:37:22"  "PT86543"
"NR 3181420"    "R" "FR"    "2012-10-12"    "18:17:54"  "2012-10-17"    "08:48:01"  "PT86543"
"NR 3183798"    "R" "FR"    "2012-02-17"    "09:32:41"  "2012-02-21"    "09:15:35"  "PT86543"
"NR 3184008"    "R" "FR"    "2012-03-29"    "11:17:04"  "2012-04-04"    "07:59:33"  "PT86543"
"NR 3185214"    "R" "CR"    "2012-08-06"    "12:45:47"  "2012-08-10"    "16:22:13"  "PH91196"
"NR 3186288"    "R" "CR"    "2012-06-27"    "08:17:48"  "2012-06-29"    "17:18:11"  "PH91196"
"NR 3186508"    "R" "CR"    "2012-04-19"    "12:11:01"  "2012-04-25"    "08:10:49"  "PT86543"
"NR 3186623"    "R" "CR"    "2012-02-21"    "15:51:35"  "2012-02-24"    "15:39:30"  "PT86543"
"NR 3186726"    "R" "FR"    "2012-07-11"    "16:08:53"  "2012-07-11"    "16:11:27"  "PA63374"
"NR 3187029"    "R" "CR"    "2012-02-17"    "08:28:43"  "2012-02-21"    "14:32:30"  "PH91196"
"NR 3188152"    "R" "FR"    "2012-03-01"    "11:44:31"  "2012-03-06"    "08:58:10"  "PT86543"
"NR 3188641"    "R" "CR"    "2012-03-09"    "10:21:32"  "2012-03-13"    "14:10:03"  "PA75075"
"NR 3190285"    "R" "SO"    "2012-03-22"    "13:14:01"  "2012-03-27"    "08:45:23"  "PA75075"
"NR 3190338"    "R" "CR"    "2012-07-11"    "15:18:56"  "2012-07-17"    "07:58:44"  "PT86543"
"NR 3190424"    "R" "CR"    "2012-09-06"    "13:36:43"  "2012-09-11"    "15:03:25"  "PH91196"
"NR 3192174"    "R" "CR"    "2012-09-04"    "13:50:36"  "2012-09-11"    "11:31:50"  "PA75075"
"NR 3195272"    "R" "CR"    "2012-03-27"    "14:55:33"  "2012-03-30"    "12:55:02"  "PT86543"
"NR 3195636"    "R" "CR"    "2012-05-09"    "12:36:34"  "2012-05-12"    "11:22:36"  "PT86543"

oanyahuru commented 4 months ago

@eve-git could the names be included as well?

eve-git commented 3 months ago

there are 12 NRs do not have corresponding names record:

-- I found the NRs by the following queries:
SELECT *
FROM events
WHERE ((event_json->>'names') IS NULL 
   OR jsonb_typeof(event_json->'names') <> 'array') 
   AND action='patch'
   and nr_id is NOT null
    AND event_json->>'note' = 'inserted manually for ticket 16316';

Also there are 762 NRs in cobrs_request but might not in namex.requests:

SELECT *
FROM events
WHERE ((event_json->>'names') IS NULL 
   OR jsonb_typeof(event_json->'names') <> 'array') 
   AND action='patch'
   and nr_id is  null
    AND event_json->>'note' = 'inserted manually for ticket 16316';

eve-git commented 3 months ago

Successful added the comments to transactions. SQL scripts: https://github.com/bcgov-registries/ops-support/blob/main/support/ops/datafix/16316-pl-sql-add-name-comments.sql and https://github.com/bcgov-registries/ops-support/blob/main/support/ops/datafix/16316-pl-sql-add-name-comments-for-conflicts.sql

eve-git commented 3 months ago

Here are the examples to test in PROD:

select * from cobrs_reqname where length(rej_cond) > 0;
"rquestno"  "choiceno"  "accrejfl"  "reqtname"  "rej_cond"
"NR 0269044"    "1" "A" "ZAMZAM TEJARA" "*** ALLOWED FOR PROPRIETORSHIP/PARTNERSHIP NAME ONLY ***"
"NR 0269752"    "1" "A" "DR. BRADLY J. BIAGIONI, INC."  "* DR *                                                      USE OF THIS TERM REQUIRES WRITTEN CONSENT FROM THE ACCREDITED BC COLLEGE AUTHORIZING ITS USE. FAX YOUR CONSENT TO 250-356-8923 FORINCORPORATION OR 250 356-0206 FOR PARTNERSHIPS/PROPRIETORSHI"
"NR 0270128"    "1" "A" "SPROTT 2017-II CORPORATION"    "CONSENT REQUIRED IF NOT GENERAL PARTNER/PROPRIETOR"
"NR 0270136"    "1" "A" "COASTAL NATURAL RESOURCE EQUIPMENT LTD."   "** WRITTEN AND SIGNED CONSENT MUST BE RECEIVED BEFORE YOU CAN INCORPORATE, PLEASE FAX  THE CONSENT TO (250) 356-8923 OR EMAIL TO CONSENT.LETTERS@GOV.BC.CA **"
"NR 0270407"    "1" "R" "JENI MACK LTD."    "* REQUIRE DESCRIPTIVE SECOND WORD OR PHRASE *               E.G. CONSTRUCTION, GARDENING, INVESTMENTS, HOLDINGS, ETC."
"NR 0270712"    "2" "A" "SURREY MAMA MIDWIFERY INC."    "* MIDWIFERY *                                               USE OF THIS TERM REQUIRES WRITTEN CONSENT FROM THE COLLEGE OF MIDWIVES OF BRITISH COLUMBIA SUITE 207, 1682 WEST 7TH AVENUE, VANCOUVER, BC V6J 4S6 604 742-2230 FAX 604 730-8908"
"NR 0271534"    "1" "A" "2589187 HOLDINGS LTD." "ONCE THE NAME OF THE CORPORATION HAS BEEN APPROVED, THE CORPORATION MUST SUBMIT A LETTER AUTHORIZING THE CONTINUATION FROM THE CORPORATION'S HOME JURISDICTION. THIS AUTHORIZATION MUST BE SUBMITTED TO THE REGISTRAR PRIOR TO FILING THE APPLICATION FOR CONTI"
"NR 0271543"    "1" "A" "LOCAL GOV GURUS"   "*** ALLOWED FOR PROPRIETORSHIP/PARTNERSHIP NAME ONLY ***"
"NR 0271921"    "1" "A" "EK&G HOLDINGS LTD."    "** WRITTEN AND SIGNED CONSENT MUST BE RECEIVED BEFORE YOU CAN INCORPORATE, PLEASE FAX  THE CONSENT TO (250) 356-8923 OR EMAIL TO CONSENT.LETTERS@GOV.BC.CA **"
"NR 0272881"    "1" "R" "THE BLUE CO."  "* REQUIRE DESCRIPTIVE SECOND WORD OR PHRASE *               E.G. CONSTRUCTION, GARDENING, INVESTMENTS, HOLDINGS, ETC."
"NR 0272881"    "2" "A" "FROM THE OCEANS"   "*** ALLOWED FOR PROPRIETORSHIP/PARTNERSHIP NAME ONLY ***"
"NR 0273352"    "1" "A" "HARCOURTS" "*** ALLOWED FOR PROPRIETORSHIP/PARTNERSHIP NAME ONLY ***"
"NR 0273899"    "1" "A" "SOMEOFAKIND"   "*** ALLOWED FOR PROPRIETORSHIP/PARTNERSHIP NAME ONLY ***"
"NR 0274166"    "1" "R" "TULIP INTERNATIONAL GROUP LTD."    "* REQUIRE DESCRIPTIVE SECOND WORD OR PHRASE *               E.G. CONSTRUCTION, GARDENING, INVESTMENTS, HOLDINGS, ETC."
"NR 0274176"    "1" "R" "GRAND EXCELSIOR INC."  "* REQUIRE DESCRIPTIVE SECOND WORD OR PHRASE *               E.G. CONSTRUCTION, GARDENING, INVESTMENTS, HOLDINGS, ETC."
"NR 0274176"    "2" "R" "CANADIAN EXCELSIOR INC."   "* REQUIRE DESCRIPTIVE SECOND WORD OR PHRASE *               E.G. CONSTRUCTION, GARDENING, INVESTMENTS, HOLDINGS, ETC."
"NR 0274176"    "3" "R" "EXCELSIOR INTERNATIONAL INC."  "* REQUIRE DESCRIPTIVE SECOND WORD OR PHRASE *               E.G. CONSTRUCTION, GARDENING, INVESTMENTS, HOLDINGS, ETC."
"NR 0275321"    "1" "A" "DUSANJH LAW"   "* LAW *                                                     USE OF THIS TERM REQUIRES WRITTEN CONSENT FROM: THE LAW SOCIETY OF BRITISH COLUMBIA. PLEASE FAX YOUR CONSENT TO 250-356-8923 INCO RPORATIONS OR 250-356-0206 - BUSINESS NAMES."
"NR 0275333"    "1" "A" "3T ENTERPRISES LTD."   "NAME REQUEST TYPE AMENDED TO ALLOW FOR POST-AMALGAMATION CHANGE OF NAME                                                                                                                            AFTER EXISTING COMPANY CHANGES NAMES OR DISSOLVES"
"NR 0275346"    "1" "A" "ISLAND DEBATE" "*** ALLOWED FOR PROPRIETORSHIP/PARTNERSHIP NAME ONLY ***"

eve-git commented 3 months ago

Hi Oge, Josh,

The name comments were added to the historical NR transactions. Please find examples to test in PROD in the ticket https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/16316

Regarding the issue of some System Transactions lacking names, typically these transactions are generated alongside processing. If preceding transactions contain name information, the System Transactions will display it from prior transactions. However, those System Transactions lacking names were inserted in 2018 from cobrs, predating newly inserted transactions. They primarily serve for technical tracking of NR states during processing. Adding names to these existing System Transactions may not be advisable, as they were imported and should remain distinct from normal NRs.

iamjtodd commented 3 months ago

Thanks @eve-git, I have gone through the list of test NRs and it's great to see the examination reasoning populating. This is one of the most important aspects of our work when explaining past decisions to clients. Was the test range only for NRs in 2017 or should it apply to NRs before 2017 as well?

eve-git commented 3 months ago

@iamjtodd The name comments apply to all the new transactions that I retrieved from COBRS records. for example

"nr_num"    "submitted_date"
"NR 3602659"    "2013-02-25 15:05:17+00"
"NR 3604943"    "2013-01-17 21:19:23+00"
"NR 3604038"    "2013-02-04 20:15:46+00"
"NR 3616334"    "2013-09-13 04:40:27+00"
"NR 3624910"    "2013-11-08 20:31:51+00"
"NR 3628782"    "2013-03-08 21:39:07+00"
"NR 0371642"    "2009-04-14 18:55:40+00"
"NR 0374329"    "2009-10-20 01:14:07+00"
"NR 0377044"    "2009-08-24 17:58:51+00"
"NR 0379530"    "2009-03-31 22:53:15+00"
"NR 0383774"    "2009-01-16 18:57:07+00"
"NR 0394190"    "2009-07-17 22:42:16+00"

The comments may not be the same as existing one. I tried to retrieve the info as more as possible, and they may from COBRS, existing names.decision_text and/or conflict names. For example,

iamjtodd commented 3 months ago

Okay thanks @eve-git

oanyahuru commented 3 months ago

@iamjtodd, are you satisfied with everything done on this?

iamjtodd commented 3 months ago

@oanyahuru yes thanks so much everyone

bcgov / entity

Transaction history before 2018 needed #16316