Closed cameron-eyds closed 1 year ago
Hey team! Please add your planning poker estimate with Zenhub @dimak1 @doug-lovett @orelbn
Please add your planning poker estimate with Zenhub @chdivyareddy
For QA and UX:
See existing MHRs in dev: 106757, 106756, 150666, 150655, 150651, 150650, 150649, 150645, 150644
Legacy MHRs to verify data: 088836, 089411, 095753, 095876, 100564
To whomever does the UX, a question i did have. It states to cap height and make the section scrollable when there is more than 6 notes. This is currently in place but that being said, did we want to cap height always regardless? The current scenario, a user could have 5 unit notes and expand them all, would result in a much larger than when they have 6 notes and a capped height to allow the scrollable section.
Super minor, just something bumped into.
To handle the varying Legacy types we may need to include some additional docTypes regardless of whether we support filing them, for display purposes of those legacy notes:
Full code list: REG_101 REG_102 REG_103 REG_103E CAU CAUC CAUE EXNR EXRE EXRS FZE NCAN NCON NPUB PUBA REGC REST STAT TAXN
Good question @cameron-eyds (about the notes table height cap). I'd assume we should cap it the same, but @LizGovier what do you want to do there? (see Cams comment for "To whomever does the UX....")
Here's a few things I noted:
[x] Only one of the grey separator/borders should be showing when there are sections hidden
[x] On MHR # 150651 this paragraph is showing, but there is no unit note at the bottom of the screen:
Hey @cameron-eyds cc @saragunnarsson
Apologies for not including this information! I was hoping each panel could close as another one open. Exactly as it works in entities (see screenshot) and in Vuetify : https://vuetifyjs.com/en/components/expansion-panels/#variant
Let me know if you have more questions.
@LizGovier @saragunnarsson Absolutely! No problem at all, will do 👍 Will update here when the changes are commit.
@LizGovier @saragunnarsson The above updates should be in dev shortly. Merged, just building!
With regards to the effective date, the display will be there if it exists in the data. I don't believe any of the dev data records contains a record with an effective date yet but we could try and create one through Postman.
@cameron-eyds This is all looking good! I'm moving it along.
Oh and if you say the effective date is in there, then that's good enough for me:)
hahah perfect :) Thank you!
Verified in DEV!
Expanded view (Notice of Caution)
Notice of Caution (expired):
Continued notice of caution (cancelled):
All buttons in unit notes section are deactivated when Transfer type is activated: