bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

UI: Unit Notes Expansion Panels in MHR Flow #16505

Closed cameron-eyds closed 1 year ago

cameron-eyds commented 1 year ago
cameron-eyds commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @dimak1 @doug-lovett @orelbn

cameron-eyds commented 1 year ago

Please add your planning poker estimate with Zenhub @chdivyareddy

cameron-eyds commented 1 year ago

For QA and UX:

See existing MHRs in dev: 106757, 106756, 150666, 150655, 150651, 150650, 150649, 150645, 150644

Legacy MHRs to verify data: 088836, 089411, 095753, 095876, 100564

cameron-eyds commented 1 year ago

To whomever does the UX, a question i did have. It states to cap height and make the section scrollable when there is more than 6 notes. This is currently in place but that being said, did we want to cap height always regardless? The current scenario, a user could have 5 unit notes and expand them all, would result in a much larger than when they have 6 notes and a capped height to allow the scrollable section.

Super minor, just something bumped into.

cameron-eyds commented 1 year ago

To handle the varying Legacy types we may need to include some additional docTypes regardless of whether we support filing them, for display purposes of those legacy notes:

Full code list: REG_101 REG_102 REG_103 REG_103E CAU CAUC CAUE EXNR EXRE EXRS FZE NCAN NCON NPUB PUBA REGC REST STAT TAXN

saragunnarsson commented 1 year ago

Good question @cameron-eyds (about the notes table height cap). I'd assume we should cap it the same, but @LizGovier what do you want to do there? (see Cams comment for "To whomever does the UX....")

Here's a few things I noted:

image.png

LizGovier commented 1 year ago

Hey @cameron-eyds cc @saragunnarsson

Apologies for not including this information! I was hoping each panel could close as another one open. Exactly as it works in entities (see screenshot) and in Vuetify : https://vuetifyjs.com/en/components/expansion-panels/#variant

Let me know if you have more questions. Screen Shot 2023-06-12 at 11.38.28 AM.png

cameron-eyds commented 1 year ago

@LizGovier @saragunnarsson Absolutely! No problem at all, will do 👍 Will update here when the changes are commit.

cameron-eyds commented 1 year ago

@LizGovier @saragunnarsson The above updates should be in dev shortly. Merged, just building!

With regards to the effective date, the display will be there if it exists in the data. I don't believe any of the dev data records contains a record with an effective date yet but we could try and create one through Postman.

saragunnarsson commented 1 year ago

@cameron-eyds This is all looking good! I'm moving it along.

Oh and if you say the effective date is in there, then that's good enough for me:)

cameron-eyds commented 1 year ago

hahah perfect :) Thank you!

chdivyareddy commented 1 year ago

Verified in DEV!

Expanded view (Notice of Caution) image.png

Notice of Caution (expired): image.png

Continued notice of caution (cancelled): image.png

All buttons in unit notes section are deactivated when Transfer type is activated: image.png