Auth Web - display Name Request type

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 58 forks source link

Auth Web - display Name Request type #16825

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

https://preview.uxpin.com/a86dccdd20ac62828f965c5eea10f81b828a9853#/pages/163299967/simulate/sitemap

[x] Add the name request type to the table based on data from Auth API.
[x] use emdash for hyphen between name and type
[x] this can be merged into main branch but needs to be feature-flagged so it is not released to prod until all the other changes are complete

severinbeauvais commented 1 year ago

See this enum for NR request types: https://github.com/bcgov/bcrs-shared-components/blob/main/src/enums/name-request-codes.ts

jdyck-fw commented 1 year ago

@PCC199 - Have a release we can tag this one to?

PCC199 commented 1 year ago

@jdyck-fw I'm not sure I understand Jason. You ask us to tag to a release then close the ticket. I must be missing something?

PCC199 commented 1 year ago

@jdyck-fw I'm not sure I understand Jason. You ask us to tag to a release then close the ticket. I must be missing something?

jdyck-fw commented 1 year ago

@PCC199 - This work has been completed. It has not been released though.

This ticket can still be tagged to the matching Relationships release that will see it pushed through the Environments.

Going by Entities definition of done, tickets don't have to be released in order to be close. Rather, they have to be releasable. SRE is an outlier in this that I know of, but to my understanding all of the other scrum teams have intentionally operated this way to not bottleneck tickets from being closed.

Lets discuss at Scrum of Scrums further to confirm we're working in a way that supports all of the teams, especially given all of the cross-team work lately.

seeker25 commented 12 months ago

I've created a release ticket, it will link here shortly.

seeker25 commented 12 months ago

This is behind a feature flag I believe. I'm deploying with it off for now. enable-name-request-type

seeker25 commented 11 months ago

enable-name-request-type has been set to true in DEV and TEST @leodube-aot let me know if it's ok to change this in PROD?

severinbeauvais commented 2 months ago

@seeker25 Can you check if the subject FF can be removed from the code now (and also from LD)?

PS The flag is True in Dev and Prod.

seeker25 commented 2 months ago

Yup looking now, on in all 3, I'll remove it

severinbeauvais commented 2 months ago

(Remove from code first, then remove from LD after deployment to Prod.)

seeker25 commented 2 months ago

already removed from code, just making sure it's not in PROD code

seeker25 commented 2 months ago

Removed from LD not in prod code