UI - Continue or extend caution

[mstanton1]

• unit note filings for continue caution and extend caution
• preserve notice of caution filing flow with expiry date update

[mstanton1]

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett @orelbn

[mstanton1]

Is expiry date and time the timestamp you do this, or end of day? @LizGovier

[LizGovier]

@doug-lovett @mstanton1 Regarding the expiry date, it would expire at the end of the day (23:59:599999)

[dimak1]

I think this ticket is missing a dependency on #16830 @orelbn

[dimak1]

Updated estimate to include work for new ExpiryDate component (with dynamic fields for different note types).

[dimak1]

Added dependency #16830 as it's required to enter CAUC and CAUE Notes.

[dimak1]

@LizGovier ready for your review.

[LizGovier]

Hey @dimak1

• [x] When I try to file the Extension to Notice of Caution, I get an error modal.

_

• [x] We're missing "Date in the future' for expiry DEV

Figma

[LizGovier]

@dimak1 For Continued Notice of Caution:

• [x] Review and Confirm page: I filled out all the fields but am getting this error:

• [x] I believe you're still working on this, but if the remarks section is not filled in, it should have (Not Entered) on the review and confirm screen

[LizGovier]

@Dima, because I am unable to file, I could not review the MHR table and unit notes.

[dimak1]

PR is reviewed. I checked the preview url and was able to submit the notes. I will merge to DEV so you can verify tomorrow. Thanks @LizGovier

[LizGovier]

@Dima

• [x] I'm not sure if the business lookup is working for submitting party

When I set the expiry date to October 31st, it shows up in the unit notes a date later (November 1st) Output with Correct Expiry Date:

Unit Note has the expiry date listed as a day later

[dimak1]

@LizGovier

1. Business lookup works in the PPR party code field, not in the Business Name field.

   

2. The date showing up as next date is something we discuss with devs, and most likely it's because of the timezones. The date picker works as per your timezone but the pacific date shows up as universal time. QA and myself have not seen the same issue on our end (because we are in PST). Divya did mention they have seen similar issues in PPR. Maybe it's worth raising a bug to look into for Effective Date. @chdivyareddy

[doug-lovett]

It looks like the UI is incorrectly converting the API UTC timestamp to pacific time: the UI is displaying 3 hours ahead for both the effective and expiry values. Here is what the api returns for this note: "notes": [ { "createDateTime": "2023-08-03T00:58:02+00:00", "documentDescription": "EXTENSION TO NOTICE OF CAUTION", "documentId": "12314123", "documentRegistrationNumber": "00501633", "documentType": "CAUE", "effectiveDateTime": "2023-08-03T00:50:02+00:00", "expiryDateTime": "2023-11-01T06:59:59+00:00", "givingNoticeParty": { "address": { "city": "TABER", "country": "CA", "postalCode": "T1G 1N8", "region": "AB", "street": "1-4630 52 AVE" }, "businessName": "SALLY LAST" }, "remarks": "Extending Notice of Caution", "status": "ACTIVE" },

[orelbn]

@LizGovier Can you please take a look.

Here is the UXA link: https://bcregistry-assets-dev--pr-1482-oxj19hhl.web.app/ Let me know if time zone issue still persist.

[LizGovier]

Hey @orelbn This is ready to move forward. I added an Extended Notice of Caution on MHR 107750 with an expiry date of Nov 30 and is showing the correct date. Thank you!

[orelbn]

@chdivyareddy I needed to update the date utility functions that are used in multiple places, so please double check that dates are still showing correctly. I checked quite a bit myself but will be good to have a 2nd eye.

Areas include date picker, unit note panels, tombstone discharge, transfer due to death.

If you want to change your time zone locally follow this steps:

1. Right-click and press on inspect

2. Press on the 3 vertical dots next to the setting icons

3. Select sensors

4. Override the location

[orelbn]

@mstanton1 @PCC199 Can we re-estimate this at a 5?

This is to account for Dima's work last sprint, Date fixes for handling different time zones, and the extra testing required to ensure the dates are displaying correctly and submitting to the API correctly.

[mstanton1]

@orelbn updated to a 5.

[chdivyareddy]

@orelbn , I'm not able to submit the 'Continued notice of caution' when the expiry date is selected as 'continued until further order of the court'. Please take a look, thanks!

Private Zenhub Image

[orelbn]

@chdivyareddy made a PR with some fixes, should be ready for review again in next hour or two.

[orelbn]

@chdivyareddy Should be good to go Let me know if you encounter anymore problems.

[chdivyareddy]

Hey @orelbn , submission for the 'Continued notice of caution' is now working in DEV, but after the filing when navigated to the unit notes to view the 'Continued notice of caution', 'Expiry date and time' is not displayed and for the remarks 'Continued until further order of the court' should be added to the top of the remarks in the CAUC unit note. In the screenshot below, 'CAUC remarks.' was manually added by me in the remarks section. Please take a look, thanks!

MHR 107781 Current behavior: Private Zenhub Image

Expected: Private Zenhub Image

[orelbn]

@chdivyareddy I can add the N/A, "Continued until further order of the court" addition to remarks are handled by the API @doug-lovett.

[doug-lovett]

@chdivyareddy @orelbn Here is the note info submitted by the UI: "note": { "documentType": "CAUC", "documentId": "63284274", "remarks": "CAUC remarks. Continued until further order of the court.", "givingNoticeParty": { "personName": { "first": "Marshall", "last": "Duncan", "middle": "S" }, "emailAddress": "email@test.ca", "phoneNumber": "4728349239", "address": { "street": "8424 Toombs Dr", "city": "Prince George", "region": "BC", "country": "CA", "postalCode": "V2K 5A3" } }, "destroyed": false, "noteId": 2 },

It is my understanding that the default text for the CAUC document type is "Continued until further order of the court.", but staff can delete it or add text before or after. The API does not modify the remarks text.

[orelbn]

@doug-lovett My apologies , ill look into how it is setting that thank you!

[chdivyareddy]

@doug-lovett , thanks for checking!

@LizGovier , can you please confirm the remarks requirement for CAUC unit note, thanks.

[LizGovier]

@chdivyareddy

Remarks are optional for CAUC. However there could be a generate message that shows up at the top of the remarks section of the Unit Note: RE: Private Zenhub Image

How it looks after filing: Private Zenhub Image

[doug-lovett]

And my apologies: for the CAUC document type where there is no expiry date, the API does append the text to the remarks "Continued until further order of the court." if it is not already present. This requirement comes from the unit notes requirements spreadsheet. I'll update the order, but I thought the UI added this text?

[chdivyareddy]

@LizGovier , thank you!! @doug-lovett , from the above screenshot only 'CAUC remarks.' portion was added in the UI.

[doug-lovett]

@chdivyareddy API update to prepend auto-generated remarks for the CAUC document type with no expiry is now in DEV.

[chdivyareddy]

Thank you @doug-lovett !

Verified in DEV!

Notice of Caution (Continued) Private Zenhub Image

Notice of Caution (Extended) Private Zenhub Image

[orelbn]

@chdivyareddy I am going to add one more commit to put, "Continued until further order of the court." On a separate line in the UI however its a minor styling change, so we can move forward with the ticket.

[dimak1]

Just my 2 cents, but looking at the comments - the fixes for Date and Time should've been a separate ticket.

[chdivyareddy]

Verified in TEST!

Private Zenhub Image