search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Tech Debt: entity emails should be stored in LEAR not AUTH #17003

Open lmcclung opened 1 year ago

lmcclung commented 1 year ago

Currently when a registered office email address is added to a business, that email is stored in AUTH. This may have been because when we started to build the Benefit company incorporation application, we thought if there wasn't an email at the profile level, when an email was added in the IA, then we'd update the profile. This mapping to the account email was later fixed so it didn't update the account email.

Because the business email is stored in AUTH, it makes retrieving this info difficult for director search. Also more complicated for migrating entities from COLIN to postgress.

lmcclung commented 1 year ago

@Mihai-QuickSilverDev can you discuss with @argush3 and @davemck513 and perhaps @kialj876 to see if this tech debit is worth tackling soon? Kial is willing to tackle it now.

This ticket arose from RTR ticket https://app.zenhub.com/workspaces/registries-benowner-644043015b6fa1002c69a9f4/issues/gh/bcgov/entity/16894

I tested business emails functionality is working and they aren't over-writing account profile emails using the following tests: Test environment bcreg2029 On account level: Clicked edit profile on bcreg2029 and there was no email address attached to that profile Selected BC1052811 from my bus registry dashboard. It was incorporated Nov 8, 2022 had no email on the bus dashboard; On account level: I added my gov't email address linda.mcclung@gov.bc.ca On BC1052811 - email in header still showed Not Available Incorporated BC1059017 BC LTD using shaw email as registered office email: linda.mcclung@shaw.ca On account level: clicked edit profile and the email address remained unchanged with my gov't email Went back to BC1052811 - changed email address on it to my outlook email: ljmcclung@outlook.com On account level: clicked edit profil and the email address remained unchanged with my gov't email

Mihai-QuickSilverDev commented 1 year ago

Thank you for raising this up, Linda! As we speak, Argus is assessing any impact this might have on the Entities code, and potential influences from the on-going Legal Name work.

jdyck-fw commented 1 year ago

@davemck513 will connect with @lmcclung for more context on this.