search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Record Conversion and Correction Outputs #17041

Open riyazuddinsyed opened 1 year ago

riyazuddinsyed commented 1 year ago

Describe the bug in the current situation When the staff files a Conversion of Record for Firms then the dashboard shows no Outputs and the user receives no email. When a correction is done for Record Conversion then the output only has the header with no context.

Steps to reproduce the behavior:

  1. Go to 'https://test.business.bcregistry.gov.bc.ca/'
  2. Log in as staff
  3. Search for a firm
  4. File a Record Conversion.
jdyck-fw commented 1 year ago

@Mihai-QuickSilverDev following up on this

Mihai-QuickSilverDev commented 1 year ago

@riyazuddinsyed I tried a Conversion Correction, and unfortunately the filing goes into Filing Pending. I wonder if we have propagated this bug to Prod too, now. See in DEV FM1002725, and in Test FM1000591. @argush3 @severinbeauvais

argush3 commented 1 year ago

This is expected behaviour for conversion corrections I believe.

We implemented conversion corrections to be a local correction not too long ago in #16858.

Mihai-QuickSilverDev commented 1 year ago

Hi Argus, yes, what is abnormal now is that the filing gets stuck on filing pending:

image.png

argush3 commented 1 year ago

I'm not entirely familiar with how local corrections are handled, but I believe that local corrections require some manual intervention by SRE or Staff?

For local corrections, the BE returns local correction filings that have a status of "PENDING_CORRECTION" in the To Do list.

I'm assuming that once the required manual updates are made to the database for the conversion correction, the filing status is set to "COMPLETED" at which point, the FILING PENDING to do is no longer displayed.

severinbeauvais commented 1 year ago

^^ I believe Argus is correct.

Conversion filings are explicitly done as local corrections: https://github.com/bcgov/business-filings-ui/blob/638977aa39cd7d86f6266e07dc322d476b2173ad/src/components/Dashboard/FilingHistoryList/HeaderActions.vue#L140

Mihai-QuickSilverDev commented 1 year ago

@riyazuddinsyed Hi Riyaz, you mentioned this above: "When a correction is done for Record Conversion then the output only has the header with no context.". Does this mean that you were able to complete a correction of a record conversion, and reach the outputs? At the moment the correction of a record conversion gets stuck in a Filing Pending state, which precludes reaching the outputs.

severinbeauvais commented 1 year ago

FWIW, I don't remember if local (manual) corrections remain as pending in the Todo List or the Filing History list.