bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Order of display of directors information #1734

Closed ghost closed 4 years ago

ghost commented 5 years ago

Describe the Bug When Sign in as a Bcorp user, the order of the details displayed for the current directors in dashboard is different from the details inside the COD stand alone filing

To Reproduce

  1. Sign in using Bcorp credentials
  2. On dashboard screen, under the current directors section notice the sequence of directors displayed
  3. Click the change button option in current directors options
  4. On change of director screen, notice the sequence of directors displayed

Actual Output The sequence of directors displayed on dashboard is different from the sequence of directors displayed inside the COD standalone flow.

Expected Output The sequence of directors displayed on dashboard should be same as sequence of directors displayed inside the COD standalone flow.

Visual Reference Dashboard Screen Screen Shot 2019-11-01 at 3.53.33 PM.png

Inside COD flow Screen Shot 2019-11-01 at 3.54.23 PM.png

Kaineatthelab commented 5 years ago

This will be looked at when the table is created. List still needs to be sorted on dashboard either by alpha or last added.

forgeuxGH5 commented 4 years ago

Interaction Design:

Director Change (including Annual Report) - List Sort Order

The default sort order of the Directors List is alphabetical (A to Z) by Director Last Name, then by Director First Name, then by Director Middle Name (in case of Directors with the same names). As new directors are add they appear in the order in which they are added - newest at the top of the list.

Other Directors Lists

The default sort order ( alphabetical (A to Z) by Director Last Name, then by Director First Name, then by Director Middle Name) applies to the following:

Wireframes: https://preview.uxpin.com/e1f6041e9f17d85709bf7fb88b8139d1726a9884#/pages/120649765

sienna-oldaccountdontuse commented 4 years ago

Added requirements to Co-op document: https://sites.google.com/freshworks.io/bcros/co-op/change-of-directors Added requirements to BComp document: https://sites.google.com/freshworks.io/bcros/bcomp/change-of-director

JohnamLane commented 4 years ago

Payment failed in Dev, so I wasn't able to verify a new director on the dashboard. The order appears correct on the dashboard and within a COD. @nitin-freshworks if you agree, this can be moved to e2e.

JohnamLane commented 4 years ago

Verified in Test for release 2.5