bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

UI - MHR Page After Filing: Adding Unit Note for EXRS and EXNR #17423

Closed LizGovier closed 11 months ago

LizGovier commented 1 year ago

When a Residential or Non-Residential Exemption is filed, a unit note gets added to the home. See Figma Designs

PCC199 commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett @RuoxuanPengBC

dimak1 commented 11 months ago

@LizGovier this is very similar to #17422. What are the differences from that ticket, is this one for Non-Residential Exemption?

LizGovier commented 11 months ago

@dimak1

This is specific to the Residential Exemption unit note that gets added to the unit note table.

LizGovier commented 11 months ago

Hey @dimak1 I was able to file a Public Note after a home is exempt, but was unable to file a confidential note: This is the error I received using this link you provided ( https://bcregistry-assets-dev--pr-1591-zmzozvg0.web.app/ )

Screen Shot 2023-10-23 at 11 54 40 AM
dimak1 commented 11 months ago

@LizGovier I assume you are talking about ticket #17422? Let me try to reproduce, which user you used to file it?

LizGovier commented 11 months ago

Hey @dimak1 Maybe this ticket should have been attached to 17422, but this error is specific to filing a confidential note after a home is exempt.

I signed in in dev as BRTEST1 and used this link : https://bcregistry-assets-dev--pr-1591-zmzozvg0.web.app/ I then tried to file a Confidential Note.

doug-lovett commented 11 months ago

@LizGovier @dimak1 for MHR 107832 in DEV, I see the following validation error response message in the gateway log: The MH registration is not in a state where changes are allowed.

The API note validation only allows a NPUB note document type when the home is an exempt state for both staff and non-staff.

dimak1 commented 11 months ago

Thanks for looking into it @doug-lovett.

@LizGovier please let me know if there is anything for me to do for 17422.

LizGovier commented 11 months ago

@dimak1 @doug-lovett Do we need to create a separate API ticket to allow a confidential note to be filed after an exemption? I also noticed that I can not cancel a Public Note after I add one to an exempt home. A user should be able to cancel any active unit note on an exempt home.

doug-lovett commented 11 months ago

@LizGovier yes please, and please identify all registrations/document types that are allowed when a home is in an exempt state. Currently registrations are not allowed by default (except for EXRE, EXNR, and NPUB). Ticket 17407 identifies NPUB as an exception; EXRE restores to active, and EXNR is allowed when an active EXRS exists.

LizGovier commented 11 months ago

@dimak1 because the errors are due to API updates, we can move this ticket forward.

dimak1 commented 11 months ago

@LizGovier for this ticket, the reference to Figma design is the same page as in other ticket, so it is done. I will move to ready for QA.

chdivyareddy commented 11 months ago

Verified in DEV for Residential Exemption.

Staff: MHR 107817 image Expanded view: image

Filed both Public Note and Confidential Note after the Residential Exemption is filed: image