Open mstanton1 opened 1 year ago
I've started a BA review to identify the current feature flags, what they appear to do, and whether they are currently enabled in PROD to guide understanding if these are still needed.
IP documentation is available here: https://docs.google.com/spreadsheets/d/14JHh67h5Ui0jxjS9Q4McuMQ4ppeu9yLnzbYYiM79WWY/edit#gid=0
@doug-lovett can you review row 14 - 19 of the attached document to let me know if we are still using, or may need those feature flags in the future? I suspect row 14 might be something that's for SRE as opposed to our team. Happy to jump in a call to explain the spreadsheet if you'd like.
@mstanton1 enable-new-feature-api is in use for PPR drafts sorting/filtering. I can see the value in keeping this flag around for future use. I am not sure why sorting/filtering is conditional for drafts but not registrations. ppr-api-1_1-EA is not in use by the API and can be removed. ppr-api-auth-caching is not in use by the API and can be removed. ppr-api-beta-registrations-client-reference-id is not in use by the API and can be removed.
The following were used for data migration search results testing in the TEST environment and can probably be removed: ppr-test-number ppr-test-boolean
Thanks @doug-lovett . I've updated the attached list and will update the body of the ticket to identify the feature flags that are no longer required.
Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett @RuoxuanPengBC
Tasks: Remove from UI Remove from API Remove from LaunchDarkly
Decision to keep mhr-ui-enabled for now
In the PPR project there are a number of feature flags. While some are still needed to toggle features, others may no longer be needed. Review is necessary to determine which feature flags are no longer necessary.
1. Remove from UI and API code then advise Melissa. 2. Remove code that is no longer needed that was controlled by flags, for instance old version of wysiwig
In DEV/TEST/PROD remove the following: assets-tiptap-enabled assets-table-enabled assets-datepicker-enabled assets-wysiwig-enabled ppr-api-1_1-EA ppr-test-number ppr-test-boolean ppr-api-auth-caching ppr-api-beta-registrations-client-reference-id financing-statement search-registration-number search-serial-number
Note a full list, showing the feature flags to delete (red) and keep (white) is available here: https://docs.google.com/spreadsheets/d/14JHh67h5Ui0jxjS9Q4McuMQ4ppeu9yLnzbYYiM79WWY/edit#gid=0