bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

API - Update subheads for PPR output templates to Title case #17746

Closed tlebedovich closed 8 months ago

tlebedovich commented 9 months ago

The design team decided we should use Title Case for the PPR subheads in cover letter/outputs versus all caps.

Header - stays as all caps Subheader - Title case updates - (do not capitalize words like "of" "and" "for" "the" etc)

Do we need a spreadsheet of how to capitalize each?

PPR Search Outputs - subhead ok as is PPR Registration Outputs - subhead needs Title Case

Examples with existing Title Case subheads:

Private Zenhub Image

Examples with all caps subheads:

Private Zenhub Image

Private Zenhub Image

tlebedovich commented 9 months ago

@forgeuxGH5 @ethantspitt @LizGovier @janisrogers - fyi ticket to make output subheads Title Case for consistency across apps

tlebedovich commented 9 months ago

@mstanton1 - lower priority obviously but if Doug has extra time one day - moved this to New Issues :)

mstanton1 commented 9 months ago

@tlebedovich Title case was mentioned as being done in grooming today. Do you want me to verify this is done with @doug-lovett before closing?

tlebedovich commented 9 months ago

yes please

mstanton1 commented 9 months ago

@doug-lovett you mentioned having tackled Title Case in an existing ticket during grooming. Can you take a look at this ticket and confirm if this is all complete? If so I will close this. Thanks!

doug-lovett commented 9 months ago

@mstanton1 the title case change that was reviewed this morning for MHR was covered in 17675. The PPR changes have not been made.

mstanton1 commented 9 months ago

@doug-lovett thank you. Updated this ticket to be PPR only and will leave it in grooming:)

doug-lovett commented 9 months ago

@tlebedovich examples are attached if you would like to review: amendment-example.pdf

financing-sg-example.pdf

financing-sa-no-changes-example.pdf

tlebedovich commented 9 months ago

thanks @doug-lovett - for the Subheads, is there a way to not capitalize words like "the" "and" "of" "under" etc. Using the way we capitalize items on the PPR table dropdown as a guide?

Private Zenhub Image

Private Zenhub Image

doug-lovett commented 9 months ago

@tlebedovich the above list is the set of registration descriptions, not the set of registration acts. Here is the list of registration acts: FORESTRY SERVICE PROVIDERS PROTECTION ACT LAND TAX DEFERMENT ACT MANUFACTURED HOME ACT, S.27/28 MISCELLANEOUS REGISTRATIONS ACT REPAIRERS LIEN ACT SALE OF GOODS ACT, S.30 FAMILY LAW ACT PERSONAL PROPERTY SECURITY ACT

As you can see, the only act with a preposition or conjunction is the one you have identified. I missed it when looking at the act list. Here is the updated report:

financing-sg-example.pdf

tlebedovich commented 9 months ago

@doug-lovett - awesome, thanks doug. this looks good to go for me.

chdivyareddy commented 8 months ago

Hey @doug-lovett , just a minor fix required for the Petroleum and Natural Gas Act Header which should stay all caps, but it currently displays as "CROWN CHARGE FILED PURSUANT TO PETROLEUM and NATURAL GAS TAX ACT", 'and' should be caps as well. Please take a look , thanks!!

Private Zenhub Image

doug-lovett commented 8 months ago

Hey @chdivyareddy this ticket is actually to change the case of the registration act, not the registration description. The reports display the database registration_types table value as is for the registration description. I have updated the db description in all environments for the registration type PG to: "CROWN CHARGE FILED PURSUANT TO PETROLEUM AND NATURAL GAS TAX ACT"

chdivyareddy commented 8 months ago

@doug-lovett , thank you!!