search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

sbc-common-components should use MDI icons #1795

Open severinbeauvais opened 4 years ago

severinbeauvais commented 4 years ago

Describe the bug The sbc-common-components were recently changed to import the Material Icons library. However, coops-ui does not import that library so the icons don't display. This can be seen in the header:

header icons.PNG

Coops-ui instead uses the Material Design Icons (https://materialdesignicons.com/). For compatibility, sbc-common-components should use the same icons.

To Reproduce Steps to reproduce the behavior:

  1. Build coops-ui to use sbc-common-components v2.0.20.
  2. Run the app.
  3. Observe the header.
sutherlanda commented 4 years ago

@jeznorth is this something you can take on?

severinbeauvais commented 4 years ago

This was done a month ago and it's looked good ever since :)