search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

UI - Inconsistency in display of the table headers while filing a COD #1801

Open ghost opened 5 years ago

ghost commented 5 years ago

Describe the Bug While filing a COD, there is inconsistency in the display of the table headers showing the details of the newly appointed directors or existing directors in COD screen flow

Dev Url: https://dev.bcregistry.ca/cooperatives/auth/

To Reproduce

  1. Sign in using Bcomp/coops user
  2. On dashboard screen, click on the change button under current directors section
  3. On change of directors screen, click on appoint new director button (When you click on appoint new director, table header is not displayed) and then click on cancel button
  4. Now, click on dropdown button next to cease button of an existing director, and select update address or update legal name(table header is displayed, which is inconsistent to step 3)

Actual Behaviour There is inconsistency. Table headers displayed while appointing a new director Table headers not displayed while updating an existing director legal name or address

Expected Behaviour Table headers are not displayed while appointing a new director or updating an existing director( Table headers are not displayed in step 3 and step 4. This should be consistent)

Visual Reference

On click appoint new director Screen Shot 2019-11-07 at 11.29.47 AM.png

On click change address for existing director Screen Shot 2019-11-07 at 11.33.03 AM.png

Already, discussed this with @forgeuxGH5

forgeuxGH5 commented 4 years ago

Let's not display the table header when a list item is in "edit" mode (Change address, Change legal name) and after the Appoint New Director button has been selected.

forgeuxGH5 commented 4 years ago

Changed my mind about this - let's look at always displaying the table header and applying a overlay, when a list item is in "edit" mode (Change address, Change legal name) and after the Appoint New Director button has been selected, on the page to disable everything but the item being edited.

Attached a mockup - this probably requires some investigation to see if we can do this in the framework. This design helps with another usability issue, so if it works it's bonus - if we can't do it I can look at an alternative design.

image

JohnamLane commented 4 years ago

This is not a bug, this is a design change, if needed.