search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Namerequest UI: should not be able to change name of historical company #18199

Open severinbeauvais opened 1 year ago

severinbeauvais commented 1 year ago
  1. do not be logged in
  2. go to https://www.names.bcregistry.gov.bc.ca/
  3. select action = change the name of an existing BC business
  4. enter existing business = BC1413400 (which is historical)
  5. observe that you can proceed with creating the NR

Expected result: cannot create NR for historical business

Actual result: "find an existing business" (business lookup) allows you to proceed

Here is a sample screenshot when doing business search. Something similar should be done for business lookup. Check with UI/UX team if unsure.

image

ozamani9gh commented 10 months ago

@PCC199 this ticket is on Entities Team Board - BACKLOG..

PCC199 commented 10 months ago

What do you want me to do with it?

From: Omid Zamani @.> Sent: Thursday, January 4, 2024 8:26 AM To: bcgov/entity @.> Cc: Couchman, Patrick CITZ:EX @.>; Mention @.> Subject: Re: [bcgov/entity] Namerequest UI: should not be able to change name of historical company (Issue #18199)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

@PCC199https://github.com/PCC199 this ticket is on Entities Team Board - BACKLOG..

— Reply to this email directly, view it on GitHubhttps://github.com/bcgov/entity/issues/18199#issuecomment-1877390115, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZXEOV5GIRMM43IFTVDOKZTYM3JY3AVCNFSM6AAAAAA6D74LCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGM4TAMJRGU. You are receiving this because you were mentioned.Message ID: @.**@.>>

severinbeauvais commented 10 months ago

The business lookup component in Namerequest UI needs to be updated to prevent the creation of a name-change NR for a historical business (by NOT looking up historical businesses).

ozamani9gh commented 10 months ago

@severinbeauvais its on your board and in BACKLOG so my team wasnt going to touch it... do you need us to groom this and our team to work on it?

severinbeauvais commented 10 months ago

Omid, it would be awesome if your team could take this one, or we could arm-wrestle for it (ie, negotiate with Dave).

ozamani9gh commented 10 months ago

@severinbeauvais its our app, we can take it. we are only supposed to work on Priority 1 tickets at the moment, does this need to be in the next sprint or two. How urgent is it?

severinbeauvais commented 10 months ago

IMHO, this is a P2. Worst case, a user creates a NR to change the name of a historical company, which they will not be able to use. It shouldn't happen often, I think.