UI - Review and Submit Transport Permit QS

[mstanton1]

For qualified suppliers

• [x] Update Review and Confirm page as per design (Figma - Review and Confirm - Transport Permit page)
• [x] Add unit tests
• [x] Submit Transport Permit (No Doc ID)
• [x] Add payment summary for submission (as request parameter)

Note: Does not cover submission of Change of Location

[PCC199]

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett

[dimak1]

Successfully submit the Transport Permit as QS.

[dimak1]

@LizGovier @saragunnarsson ready for UXA: https://bcregistry-assets-dev--pr-1727-g5fqq8uy.web.app

[saragunnarsson]

Thanks @dimak1 I'll check it out!

[saragunnarsson]

Hey @dimak1 Just a few small things noted below:

• [x] 2 minor style edits in the below screenshot

• [x] Tax certificate showing where it shouldn't

• [ ] A couple style edits in the Authorization table
• [x] Authorization text is wrong

[dimak1]

Thanks @saragunnarsson, I will look into these.

[dimak1]

@saragunnarsson all updates are done, except one. Link: https://bcregistry-assets-dev--pr-1727-g5fqq8uy.web.app/

Authorization styling is probably broken because of a Vue3 upgrade. This Authorization component is reused across many flows, and (since it is not a breaking change) to keep the other work going, we created a general post-upgrade UI/UX fixes ticket, so maybe we can add this styling fix there? #18903

[saragunnarsson]

@dimak1 I see, that's all good. I still see the tax certificate on the move within the same park..but other than that it looks good!

[dimak1]

@saragunnarsson hmm that should be fixed, checking...

[dimak1]

@saragunnarsson I just got clarification from @LizGovier that Tax Certificate would not show only if the current location of the home is Dealer's / Manufacturer's lot. So, in this case (screenshot) it would show.

[dimak1]

@saragunnarsson @LizGovier if there are no outstanding issues, please let me know, I will merge the changes and deploy to DEV. Thank you

[saragunnarsson]

ahh I see, sorry about that @dimak1 - then this can move along to RFQA

[chdivyareddy]

Hey @dimak1 , I'm seeing the following error for the QS account transport permit submission in TEST. Can you please take a look, thanks!!

MHR 108107 in TEST: BCREG0051 (QS Test Account)

errorMessage "API backend third party service error." rootCause "detail:[Additional validation: The existing location must be a dealer or manufacturer lot for this registration. ],message:003: Registration request data validation errors. "

[dimak1]

Hi @chdivyareddy I had this error as well, and asked @doug-lovett about it. It is basically the user role issue.

Only the Manufacturer can file this type of Permit. There are some rules, the API catches them, but UI does not. Maybe there are some UI improvements we can make it more clear @LizGovier

[LizGovier]

@dimak1 Regarding this UX A question

@saragunnarsson I just got clarification from @LizGovier that Tax Certificate would not show only if the current location of the home is Dealer's / Manufacturer's lot. So, in this case (screenshot) it would show.

The question you asked me did not reflect what Sara was asking. The flow for moving within the same Manufactured home park does not contain a tax certificate component, therefor you would not see this on the review and confirm page.

[LizGovier]

@chdivyareddy and @dimak1

There is ticket #19626 that covers QS restrictions (design link) that Cameron is working on.

[chdivyareddy]

@dimak1 @LizGovier , the above error occurred when submitting the location type Transport Permit (Dealer's / Manufacturer's lot) not the manufactured home park.

[LizGovier]

@chdivyareddy, is this is regarding the role that Dima mentioned above?

Hi @chdivyareddy I had this error as well, and asked @doug-lovett about it. It is basically the user role issue.

Only the Manufacturer can file this type of Permit. There are some rules, the API catches them, but UI does not. Maybe there are some UI improvements we can make it more clear @LizGovier

Is so, then it looks like Cameron is working on ticket #19626 that covers QS restrictions depending on the QS type (Lawyer/Notary, Manufacture, Dealer)

[chdivyareddy]

@LizGovier thanks for clarifying!!

[dimak1]

@saragunnarsson here is the new link with fixes for Tax Certificate date on the Review page: https://bcregistry-assets-dev--pr-1737-j34z4vpv.web.app/

[saragunnarsson]

Looking good @dimak1 ! Moving this along to rfqa

[chdivyareddy]

Hey @dimak1 , Transport permit location type is working as expected, but when the location type is "Transport Permit - Moving within the same Manufactured Home Park". Can you please take a look, thanks!!

{ "errorMessage": "API backend third party service error.", "rootCause": "detail:[Additional validation: Dealer/manufacturer name, band name, reserve number, parcel ID, and LTSA details are not allowed with a MH_PARK location type. ],message:003: Registration request data validation errors. " }

When I navigate back, this is the validation bug I'm seeing:

[dimak1]

@chdivyareddy thanks, I will take a look, which MHR number is this?

[dimak1]

@chdivyareddy I fixed the data preseravtion (for Pad) and PR is opened.

For the submission issue, I was able to reproduce it with a different error. Most likely, it's an issue with the QS sub-roles. The roles specify which Permit can be filed. In UI we don't have a way to distinguish but, but API blocks it, with different error messages (depending on role and payload data).

[chdivyareddy]

@dimak1 , thanks for the quick fix, the issue was with MHR 065230 in DEV.

[dimak1]

@chdivyareddy the Bcreg0018 (MyMhrTestBusiness) is Lawyer and Notary QS, so they should be able to file any Permit. I will look into it.

[doug-lovett]

@dimak1 to avoid any API issues mapping the access group from the JWT roles, please use these accounts for testing the different qualified suppliers. After a status meeting discussion last week Divya created them. BCREG0050 - QS Home Dealer Account (ID: 3249) BCREG0062 - QS Lawyers and Notaries Account (ID: 3248) BCREG0061 - QS Manufacturer Account (ID:3250)

[dimak1]

@chdivyareddy Fixed the payload data and was able to submit using BCREG0062 (Transport Permit - Moving within the same).

[chdivyareddy]

Verified in DEV!