bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Editing NR after Submission #18872

Open Rajandeep98 opened 9 months ago

Rajandeep98 commented 9 months ago
image.png

while editing the submitting request, It gave error while editing from user side however it stored the submitting data as many times the submit button was clicked and also showed on the user screen that many times.

Rajandeep98 commented 9 months ago
image.png
iamjtodd commented 8 months ago

Has this issue since found a solution?

Rajandeep98 commented 8 months ago

looking into it, has there been any similar issues in prod? we found this bug while testing in dev environment, if you have any nr's relate to this issue, please comment here!!

iamjtodd commented 8 months ago

Nothing recent, only the example from #3433

ozamani9gh commented 8 months ago

@mengdong19 can you assist Rajan with this ticket... this one needs to get fixed sooner than later... perhaps you both can work together and figure out how the 2nd name choice gets clobbered

Rajandeep98 commented 8 months ago
image.png image.png
Rajandeep98 commented 8 months ago

i can create a nr then i can go back and edit the nr from user side and update the 3rd nr request without completing the second nr i think we can fix this by making them to be filled in order required something

Rajandeep98 commented 8 months ago

only ones with no designation types having issue they are not restricted to go by order of updating names in edit field

mengdong19 commented 7 months ago

I'm not able to reproduce the issue this ticket original described, but find another issue while testing. When I edit NR and try to remove second option, also update 3rd option, the third one got updated, but the second one still there. image

Try to remove and update: image

Third one updated, second one still there. image

I'm able to reproduce the issue Rajandeep commented above.

Checked the number of NRs that has third option but does not have second option is 3198, about 0.31%

@ozamani9gh Should we fix above two bugs in this ticket or create another two bug tickets to fix them?

mengdong19 commented 7 months ago

Find similar data in prod as ticket initially described. The list of all NRs that has issue: id | nr_num | state_cd | request_type_cd | last_update
---------+------------+------------------+-----------------+------------------------------- 856250 | NR 7666718 | REJECTED | FR | 2021-06-11 15:25:37.190864+00 1002685 | NR 0951802 | CANCELLED | CFR | 2021-06-11 13:27:36.777531+00 1018518 | NR 3286244 | EXPIRED | CR | 2021-06-11 13:15:06.033705+00 1788111 | NR 4814640 | CONSUMED | XCR | 2021-06-11 02:49:47.994329+00 2053548 | NR 5788869 | CONSUMED | FR | 2021-06-10 18:43:41.383204+00 2061919 | NR 9876312 | EXPIRED | FR | 2021-06-10 18:34:41.510633+00 2168641 | NR 8497583 | CANCELLED | FR | 2021-10-22 21:04:26.836572+00 2168642 | NR 4062192 | CANCELLED | CR | 2021-11-04 16:38:45.387897+00 2234839 | NR 6595642 | REFUND_REQUESTED | CR | 2022-03-27 16:41:34.538287+00 2416290 | NR 6848075 | EXPIRED | FR | 2023-09-18 08:01:11.02096+00 2483253 | NR 3919923 | REFUND_REQUESTED | FR | 2023-12-14 23:13:01.319245+00 2484226 | NR 9391451 | REFUND_REQUESTED | FR | 2023-12-19 18:17:18.64022+00 2485632 | NR 3661109 | REFUND_REQUESTED | CCR | 2023-12-21 01:57:41.47936+00 2486084 | NR 8350917 | REFUND_REQUESTED | FR | 2023-12-24 15:48:39.067151+00 2486786 | NR 1550294 | REFUND_REQUESTED | CR | 2023-12-26 07:01:57.597924+00 2487630 | NR 1481835 | REFUND_REQUESTED | CR | 2023-12-29 04:37:50.997839+00 2489568 | NR 7323407 | REFUND_REQUESTED | CR | 2024-01-03 23:00:35.921676+00

Sample NRs from above list.

image

image

image

image

image

image

image

mengdong19 commented 7 months ago

New tickets created for above two new issues: https://github.com/bcgov/entity/issues/19690 https://github.com/bcgov/entity/issues/19688

mengdong19 commented 7 months ago

Can not reproduce issue on test. There's system glitch during December, these data might affected by the system glitch. Since all recent affected NRs are all refunded, will keep data as is for future investigate in case any new similar data comes up. Move to icebox to monitor this issue.