bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

PPR Vehicle Collateral and General Collateral #18914

Closed mstanton1 closed 5 months ago

mstanton1 commented 6 months ago

Expected:

image.png

Expected:

image.png

Current:

image.png image.png

Expected

image.png image.png

Data:

image.png

Submission error:

image.png

All PPR Amendment flows with vehicle collateral:

Screen Shot 2023-12-14 at 4.18.07 PM.png

Amendment:

Screen Shot 2023-12-14 at 4.12.09 PM.png
chdivyareddy commented 6 months ago

@cameron-eyds Just an FYI - adding new scenarios in the description if I find any, thank you!!

cameron-eyds commented 6 months ago

@chdivyareddy Absolutely, sounds good! Thank you for the heads up

cameron-eyds commented 6 months ago

@mstanton1 I looked into the PPR General Collateral item where it is also failing under the same scenario in TEST. Are these filing types that require the General Collateral missing a default value maybe? I'm not certain of initial requirements but perhaps that might be the case here and if so, what would the default values be?

chdivyareddy commented 6 months ago

@cameron-eyds , here is the spreadsheet for the default GC text. https://docs.google.com/spreadsheets/d/18eTumnf5H6TG2qWXwXJ_iAA-Gc7iNMpnm0ly7ctceTI/edit#gid=0

cameron-eyds commented 6 months ago

@chdivyareddy Thanks Divya! Will give this a look

chdivyareddy commented 6 months ago

@cameron-eyds , Validation is missing for the crown charge registrations where GC is required, when user clicks on the Review & Confirm screen without entering the GC text, then the stepper gets checked. Please take a look, thanks!!

image.png
cameron-eyds commented 6 months ago

@chdivyareddy Fixed it, although i'm a little confused how this happened. Might take a few and look a little deeper.

chdivyareddy commented 6 months ago

@cameron-eyds @mstanton1 , Just one minor fix required as part of validation, not sure whether this can be updated as part of UXA ticket. Please take a look, thanks!!

Expected:

image.png
cameron-eyds commented 6 months ago

@chdivyareddy I'm not entirely sure if there was auto-scrolling to components in PPR the same way there is in MHR, do you recall?

Either way, we need to be careful about getting bogged down on these net new functionalities that didn't exists previously. These new validations were missed requirements when Crown Charge Registrations allowed optional vehicle collateral and we've spent a bit of time of this now, i'm thinking it's now best to create a new ticket for any additional enhancements. Thoughts on this @mstanton1 ?

mstanton1 commented 6 months ago

@cameron-eyds @chdivyareddy I can see the point here. These are great things to call out but it could be a slippery slope if we commit to resolving each item, particularly if some may have existed before.

For the autoscroll if you're both okay with it I could log that as a separate bug? For the error on collateral showing for vehicle collateral and general collateral I have slightly more concern that a user will think both are required which could result in calls. Are you okay with keeping that one as part of this ticket's scope?

cameron-eyds commented 6 months ago

Absolutely! Already updated 👍

mstanton1 commented 6 months ago

Thank you. Pulling the autoscroll into another ticket now:)

chdivyareddy commented 6 months ago

Verified in DEV!

image.png image.png