Closed mstanton1 closed 5 months ago
@cameron-eyds Just an FYI - adding new scenarios in the description if I find any, thank you!!
@chdivyareddy Absolutely, sounds good! Thank you for the heads up
@mstanton1 I looked into the PPR General Collateral item where it is also failing under the same scenario in TEST. Are these filing types that require the General Collateral missing a default value maybe? I'm not certain of initial requirements but perhaps that might be the case here and if so, what would the default values be?
@cameron-eyds , here is the spreadsheet for the default GC text. https://docs.google.com/spreadsheets/d/18eTumnf5H6TG2qWXwXJ_iAA-Gc7iNMpnm0ly7ctceTI/edit#gid=0
@chdivyareddy Thanks Divya! Will give this a look
@cameron-eyds , Validation is missing for the crown charge registrations where GC is required, when user clicks on the Review & Confirm screen without entering the GC text, then the stepper gets checked. Please take a look, thanks!!
@chdivyareddy Fixed it, although i'm a little confused how this happened. Might take a few and look a little deeper.
@cameron-eyds @mstanton1 , Just one minor fix required as part of validation, not sure whether this can be updated as part of UXA ticket. Please take a look, thanks!!
[x] For the crown charge registrations, GC is a required field and if the user doesn't enter the text in the editor, then the stepper is not checked which is as expected, but when the user navigates back from the review screen to the General collateral screen, then the red vertical error bar appears to the Vehicle collateral as well:
[x] ~When user hits register and pay button without finishing the required fields, then the user is not auto-scrolled to the component:~ Moved to #19083
Expected:
@chdivyareddy I'm not entirely sure if there was auto-scrolling to components in PPR the same way there is in MHR, do you recall?
Either way, we need to be careful about getting bogged down on these net new functionalities that didn't exists previously. These new validations were missed requirements when Crown Charge Registrations allowed optional vehicle collateral and we've spent a bit of time of this now, i'm thinking it's now best to create a new ticket for any additional enhancements. Thoughts on this @mstanton1 ?
@cameron-eyds @chdivyareddy I can see the point here. These are great things to call out but it could be a slippery slope if we commit to resolving each item, particularly if some may have existed before.
For the autoscroll if you're both okay with it I could log that as a separate bug? For the error on collateral showing for vehicle collateral and general collateral I have slightly more concern that a user will think both are required which could result in calls. Are you okay with keeping that one as part of this ticket's scope?
Absolutely! Already updated 👍
Thank you. Pulling the autoscroll into another ticket now:)
Verified in DEV!
Expected:
Expected:
Current:
Expected
[x] PPR - Forest Act, Mineral Land Tax Act, Petroleum and Natural Gas Act, Taxation (Rural Area) Act, Property Transfer Tax Act, Other, School Act: When the General Collateral is not entered which is an optional field in this filing, but when the user tries to submit the filing, the following error is displayed:
"errorMessage": "API backend third party service error.", "rootCause": "detail:[Additional validation: General Collateral is required with this registration type. ],message:003: Financing Statement request data validation errors. " }
Data:
Submission error:
All PPR Amendment flows with vehicle collateral:
Amendment: