Closed mstanton1 closed 4 months ago
@cameron-eyds ticket ready to go
For the first issue (where the Delete button is not showing), I noticed that it sometimes does not register the selected Transfer Type, so I had to select it twice to get the Delete button to show. Just the observation to help with the investigation of the bug.
Fixed the first issue with small code change (will open PR soon). For the second issue, the API is rejecting the submission, and I think because the MHR 107829 is exempt. However, there are no active exemptions notes, so the exemption message at the top of the page is not showing.
rootCause : "detail:[Additional validation: The MH registration is not in a state where changes are allowed. ],message:003: Registration request data validation errors. "
@tlebedovich
@tlebedovich as discussed, please let me know when I can re-try the submission. For now, I will open the PR for the first issue fix. Thanks!
@dimak1 - last item above looks to be due the fact the home is Exempt (due to STAT). A ticket has been created to make sure all Exempt homes (no matter the reasons) show an "Exempt" view of the MHR Info screen that would stop any transfers/location changes. I created a new MHR 107948 with similar owner structure as 107829 and the transfer was able to go through.
@tlebedovich thanks for clarification. For the first issue, it is still happening in DEV, it seems the fix didn't help. I will try another approach and move to QA once ready.
@dimak1 , for the transfer type joint tenants, I was unable to submit the filings, and also I sometimes (not always) notice the Delete button and Delete all owners/groups button is not displayed. Please take a look, thanks!!
Joint Tenants: MHR 107954
{ "errorMessage": "API backend third party service error.", "rootCause": "detail:[Additional validation: A removed business owner corporation number is required with this registration. ],message:003: Registration request data validation errors. " }
@chdivyareddy, for the submitting issue, the API is requiring additional info (business owner corporation number) to be submitted with any deleted business owner. We don't have it implemented in UI, the ticket to add that is in backlog. Please try with a reg owner.
For the Transfer Type dropdown issue, apparently, the two fixes (which seemed to be working in my local) are not working in DEV. I'll have to take another look. Thanks!
@dimak1 , thanks for the info, will take a look!!
@dimak1 , when there is no business owner in the Joint Tenants transfer filing, then the filing did work as expected in DEV.
@chdivyareddy thanks for verifying. So the only issue that's left is with the Transfer Type dropdown?
@dimak1 , Yeah that's right!
@chdivyareddy if you have a consistent way of reproducing this issue, please let me know. I'm looking into it again to see what else could be done. Thanks.
Fixed by Cameron in https://github.com/bcgov/ppr/pull/1686
It's now in DEV! Should this move back to RFQA or was there other items pending?
Thanks Cameron, this was the only pending fix. Moving along.
@dimak1 @cameron-eyds , the issue for the dropdown noted is working as expected.
I see there was other new issue noted above in the description for Transfer Due to sale when the home owners section contains Execs/Admin/Trustee and by adding new owners group blocks the transfer from completing the filing (MHR 107829 in DEV - I have added a draft under the filing you can reproduce the issue using the draft). Can you please take a look, thanks!!
@chdivyareddy thanks for verifying the dropdown. I will look into the transfer issue.
@doug-lovett We would need your help here.
Transfer for MHR 107829 has no UI errors but still cannot be submitted.
rootCause: "detail:[Additional validation: The MH registration is not in a state where changes are allowed. ],message:003: Registration request data validation errors. "
Could you pls let me know if you can see more details? Thanks
@dimak1 107829 is in an EXEMPT state: is the current location outside of BC?
Thanks @doug-lovett, the location is in BC. And UI is showing active, so maybe that's a bug, cc: @LizGovier
@dimak1 that is only one reason the home may be exempt. Are you working from an outdated draft? The API is returning a status of EXEMPT.
"clientReferenceId": "",
"createDateTime": "2023-10-13T13:03:27-07:00",
"documentId": "12264576",
"documentRegistrationNumber": "00501920",
"hasCaution": false,
"lienRegistrationType": "",
"locationType": "MH_PARK",
"mhrNumber": "107829",
"ownerNames": "HILTON CAMPBELL,\nABC WAREHOUSING LTD.,\nWESTBANK SERVICES INC.,\nTANISHA R KELLER,\nRAINFIELD SERVICES LTD.,\nJOHNNY HOFFMAN",
"path": "/mhr/api/v1/registrations/107829",
"registrationDescription": "MANUFACTURED HOME REGISTRATION",
"registrationType": "MHREG",
"statusType": "EXEMPT",
"submittingParty": "INFOSEARCH RESEARCH SERVICES",
"username": "BUSINESS REGISTRY TEST 1"
And in DEV it is showing as exempt in the UI dashboard.
@chdivyareddy Divya flagged a bug for this Draft which could not be submitted. So maybe there is some disconnect between the MHR and its drafts. Maybe if MHR is exempt the drafts should be exempt too? @doug-lovett @LizGovier
@mstanton1 - It would be good to work on the "Draft is outdated" error handling ticket which would eliminate issues like the one above. c/c @dimak1 @doug-lovett @chdivyareddy
Thanks @tlebedovich, so you are saying the above issue (draft submission error) is not actually an issue? cc @chdivyareddy in this case maybe we can move ticket along if there are no other issues?
@tlebedovich thanks for the recommendation on prioritizing the draft work! I've ordered the backlog placing the Transport Permit completion and user flows at the top. After that I've included the correction API work and the "Draft no longer valid" (15820) and "Changes cannot be saved" (15846) tickets.
@dimak1 @chdivyareddy @LizGovier @mstanton1 - I think this ticket can move along personally. I had created a net new MHR with the same ownership structure as 107829 before the holidays to test and was able to submit it ok.
I think the issue for 107829 is because the home is Exempt and we shouldn't be able to do transfers when the home is Exempt from the MHR Info page. This MHR doesn't have the correct Exempt view to stop that from happening (it was exempted due to Registered Location change).
So in near future we should:
a) work on the outdated Draft handling ticket and b) work on the Exempt views ticket Liz has created. MHR 107829 is not showing the right Exempt view because it was exempted due to a Registered Location change and we need to get the Exempt view state working for all Exempt homes no matter the cause of exemption.
@tlebedovich Thanks for the update, will move this along!!
Transfer due to Sale/Gift:
When I select Sale/Gift transfer type and it activates the homeowner table:
Seen on MHR 107899 - has Transport Permit but you should still be able to delete existing owners
dev note: Unit Notes and Transport Permits do not stop staff from doing a transfer so not sure why the buttons are missing in some specific cases.
Transfer to Surviving Joint Tenants:
Transfer due to Sale/Gift: