search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Remove Sentry #19035

Open thorwolpert opened 12 months ago

thorwolpert commented 12 months ago

Updating ticket purpose as per notes below. Rather than leveraging Sentry for error logging RTR will use Google Cloud. This ticket is for the btr_api and business search api to remove Sentry.

~Original ticket for:~ ~Sentry Proxy Given A user is entering sensitive data into the system When there is an error that is trapped and reported Or the error is not handled and is reported by the default handler Then The Sentry proxy will filter out any sensitive data before registering the event in the SaaS service~

mstanton1 commented 3 months ago

@pwei1018 @thorwolpert are BTR errors actually being picked up in Sentry? Is this the longer term intention?

pwei1018 commented 3 months ago

@mstanton1 @thorwolpert I suggest to get rid of sentry. We can use Google Cloud logging to do the same thing and also protect the data.

mstanton1 commented 3 months ago

@pwei1018 that sounds like a much better route. Do you know if any of the BTR information is currently being pushed to Sentry? If not, I will check with my team (to make sure we aren't doing that and confirm I can just close this ticket).

pwei1018 commented 3 months ago

@mstanton1 The btr_api and business search api are using Sentry. You can ask your team to remove it.

kialj876 commented 2 months ago

@pwei1018 @thorwolpert do you have any existing projects with this monitoring setup? If not I will just follow the documentation here https://cloud.google.com/logging/docs/alerting/log-based-alerts

I also have the same question for the frontend monitoring? Are we using firebase monitoring there? This ticket won't handle any front end monitoring, but would be good for me to know whats in place for that / what the plan is for ops

kialj876 commented 2 months ago

@mstanton1 we also need to block this by moving the search queues into GCP and the importers into GCP (not sure where those tickets went we probably need new ones). Most of the important monitoring messages for search comes from those and they live in OCP land / using sentry

mstanton1 commented 2 months ago

@kialj876 I've looked for the ticket to add as blockers and found one (21139) to update logging levels in GCP but could not find anything specific to search queues or importers. If a new ticket is necessary let's create it in grooming.