bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

Create UI: implement "Continuation Authorization" component (step 1) #19265

Open JazzarKarim opened 4 months ago

JazzarKarim commented 4 months ago

See Figma, ie:

image.png

To do

image.png
severinbeauvais commented 1 month ago

@yuisotozaki @NaveenHebbale Do we have an answer yet on whether multiple uploads must be supported?

NaveenHebbale commented 1 month ago

Business wants multiple files to be uploaded, What will be the extra effort? if the effort is more? We will go with a Single file upload with a note to the Client "Merge all documents into one PDF" .

@OlgaPotiagalova

severinbeauvais commented 1 month ago

Yes, it's more effort to support multiple file uploads, but it looks like we can just have multiple instances of the common file upload component, so maybe it would be an extra "2" to do it.

Here's how it might look. @yuisotozaki , is this OK? I'm thinking we'd just add an extra file upload when they've used one. This also seems to support deleting a selected file.

image

yuisotozaki commented 4 weeks ago

@severinbeauvais Let's give that a go.

severinbeauvais commented 1 week ago

Test Notes

In this ticket, the common File Upload component was cleaned up a little. Therefore, all users of this component should be tested to ensure files can be selected, are validated, and can be saved and resumed later. SB has tested a few of these. The following filings are impacted:

Sample dissolution: https://dev.create.business.bcregistry.gov.bc.ca/dissolution-affidavit?id=CP0001230 Sample continuation in: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-review-confirm?id=TmCY3xvKFc

Try the following:

yuisotozaki commented 4 days ago

Sprint review demo, design team input, and business input have created a revision to the design. This ticket is being UX assured against the original design at the time of development ticket creation.

Ready for QA.