COLIN Sync - Incorrect COLIN filing type used for alteration filing synchronization (BC to Benefit).

eve-git commented 9 months ago

We have a job running hourly to sync alteration filings between BC and Benefit. During syncing BC to Benefit filings, we use 'NOALA' (Alteration of Company Information) as the COLIN filing type. However, it should actually be 'NOALE,' indicating an alteration from a BC Company to a Benefit Company.

As per David R., COLIN alteration filing types below:

NOALA FILING Alteration of Company Information Notice of Alteration NOALD BENCOM Alteration from a BC ULC to a Benefit Company Alteration from a BC ULC to a Benefit Company NOALE BENCOM Alteration from a BC Company to a Benefit Company Alteration Application from a BC Company to a Benefit Company NOALR BENCOM Alteration from a Benefit Company to a BC Company Alteration Application from a Benefit Company to a BC Company

https://docs.google.com/document/d/1epRhvE7uwXnHQ15FRxgh7Pi_rBSPLCth/edit

Mihai-QuickSilverDev commented 8 months ago

@eve-git

[ ] Synch process from BCROS --> COLIN should only apply to BEN company types
[ ] The BEN-->BC company type alteration is not live in BCROS.
[ ] When an Ops developer completes this filing manually, then they should use the correct filing type in COLIN.
[ ] A list of COLIN filing types was added in this ticket's description.
[ ] Names team will verify synchronization now works as expected.
[ ] Names Team to fix any old alteration issues @ozamani9gh @rarmitag

OlgaPotiagalova commented 5 months ago

Filing types reference table:

OlgaPotiagalova commented 5 months ago

More information from the e-mail from Michael Kagis:

"Here’s a screenshot of the ledger for BC1257470, which David R. points to in his email below (note the hyperlinks for Notice of Alteration and Notice of Articles in the Notice of Alteration filing below; those are filing outputs that COLIN is providing):

Now, contrast that screenshot, where the incorrect filing type was passed to the legacy system, with this one. For the alteration filing on BC1234376, the correct filing type was used to sync data back to legacy infrastructure. Not only is the same of the filing now correct for its purpose, but COLIN also is displaying no outputs, which I understand to be the correct and expected behaviour. The underlying idea there is that, when a limited company alters itself to become a benefit company, the system of record is BCROS and, therefore, the filing outputs only should be displayed in that system.

"

Take away from the above :

"When data is synced back to legacy applications, modern infrastructure needs to be very detail-oriented about the data that is being passed back. The secondary takeaway, though perhaps the more interesting one, is that the filing dates here are interesting. The filing that synced back incorrect data, in David’s example, came from just yesterday, May 17, 2024. However, the filing that provided the correct data came from just 6 months ago, December 5, 2023. Moreover, we have records of the correct data being synced back to the legacy systems as late as March 28, 2024 – just over 6 weeks ago.

This secondary takeaway leads to a very interesting question: what happened roughly 6 weeks ago? My understanding is that these alteration filings, for pushing back to legacy infrastructure, are Jupyter Notebooks, which I understand to be scripts that developers run. Am I correct there? If yes, how do developers implement these Jupyter Notebooks? Do they work from one standard script? Or do they each have their own scripts?"

Mihai-QuickSilverDev commented 5 months ago

@OlgaPotiagalova @MKagis Hi Olga, Michael,

[ ] There is one Alteration Jupyter Notebook template used by all Ops Developers.
[ ] Once the Alteration Jupyter Notebook is executed, the Ops Developer will wait for the BCROS to COLIN API Synch to take place.
[ ] As per executive decision made about one year ago by Linda, the Alteration is going to be the last filing in the ledger of the source system.
For example, for a BC LTD ---> BEN alteration, COLIN record will end with the alteration and the BCROS record will start with the alteration. And viceversa.
Previous ledger transactions would not be carried over from one system to another.

severinbeauvais commented 5 months ago

Mihai, won't the COLIN data be imported into BCROS around MVP? How do you see the COLIN-only ledger items syncing with the BCROS-only ledger items?

severinbeauvais commented 5 months ago

Is there a simple list of things that need to be implemented in this ticket?

severinbeauvais commented 5 months ago

Note: per Vysakh, we do not currently sync ULC and CCC to COLIN, so that is either a pre-requisite or else we can only handle BEN and BC atm.

rarmitag commented 5 months ago

@severinbeauvais - no simple list, but this ticket was originally just for Alteration of Ltd to Ben. which involves changing the filing type code from NOALA to NOALE.

severinbeauvais commented 5 months ago

Thanks, Richard. It's just that I see a lot of checkbox todo items above, and side conversations.

If we limit the scope of this ticket to what you said then we are ready to estimate and implement this ticket. cc @NaveenHebbale

rarmitag commented 5 months ago

I would limit the scope for this, just to sure that you're not changing too much. This sync job is really important and can't break. So please change it with caution.

OlgaPotiagalova commented 5 months ago

Agreed. Let's limit the scope of this ticket to just fixing the codes used in syncing alterations

[ ] Use "NOALE" instead of "NOALA" for Alteration filings between BC and Benefit company
[ ] Names Team to verify synchronization works as expected.
[ ] Names Team to fix any old alteration issues (relevant to the scope of this problem)

Additional tickets will have to be created - TBD

vikas-gov commented 2 months ago

@vysakh-menon-aot and @Mihai-QuickSilverDev to connect on scenarios/questions today 08/20

vikas-gov commented 2 months ago

@riyazuddinsyed will connect with Names team

vikas-gov commented 2 months ago

reviewed with @rarmitag, he will test it today

vikas-gov commented 2 months ago

Richard is working to setup Jupyter Notebook for the testing.

vikas-gov commented 1 month ago

Sid C has been assigned this work as Jupyter nb is working for him. Actively being tested

vikas-gov commented 1 month ago

Reviewed with Omid, no further testing needed. Any operational issues that come up will be taken up by Ops Support.

vikas-gov commented 1 month ago

@riyazuddinsyed add scenarios that do not work through UI

severinbeauvais commented 1 month ago

I just tested this in Dev.

CUL = https://dev.business.bcregistry.gov.bc.ca/C9900773

start an alteration
change business type to BC Benefit Company
file the alteration
see error:

severinbeauvais commented 1 month ago

The filing data for my test above:

https://dev.edit.business.bcregistry.gov.bc.ca/C9900773/alteration/?alteration-id=150918&accountid=3040

vysakh-menon-aot commented 1 month ago

@severinbeauvais This error is specific to C type. Check with BC types

severinbeauvais commented 1 month ago

New test with ULC = https://dev.business.bcregistry.gov.bc.ca/BC0871495/?accountid=3040

Test was successful:

severinbeauvais commented 1 month ago

Filing data for test on a ULC -> BEN (different business from above but same test):

https://dev.edit.business.bcregistry.gov.bc.ca/BC0871516/alteration/?alteration-id=150920&accountid=3040

severinbeauvais commented 1 month ago

The data for a ULC -> BEN looks identical (except for ids and business type) to the data for a CUL -> BEN.

cc: @vysakh-menon-aot

OlgaPotiagalova commented 1 month ago

Please add the information about:

the scope of the changes (to my knowledge it was expanded to other alteration types, not just Alteration filings between BC and Benefit company, as stated above)
the scope of the verification conducted

Additional checks will have to be done by the Names team

vysakh-menon-aot commented 1 month ago

COLIN Sync supported alteration filings:

 'BEN': 'NOABE',  # No corp type change
 'BC': 'NOALA',  # No corp type change
 'ULC': 'NOALA',  # No corp type change
 'CC': 'NOALA',  # No corp type change
 'CBEN': 'NOABE',  # No corp type change
 'C': 'NOALA',  # No corp type change
 'CUL': 'NOALA',  # No corp type change
 'CCC': 'NOALA',  # No corp type change
 'BC_TO_BEN': 'NOALE',
 'BEN_TO_BC': 'NOALR',
 'ULC_TO_BEN': 'NOALD',
 'ULC_TO_BC': 'NOALB',
 'BC_TO_ULC': 'NOALU',
 'BC_TO_CC': 'NOALC',
 'C_TO_CBEN': 'NOALE',
 'CBEN_TO_C': 'NOALR',
 'CUL_TO_CBEN': 'NOALD',
 'CUL_TO_C': 'NOALB',
 'C_TO_CUL': 'NOALU',
 'C_TO_CCC': 'NOALC'

riyazuddinsyed commented 1 month ago

Verification of this ticket will be done Names team as pointing the Jupyter notebooks to test is a complicated process.This will be verified once an Alteration happens in the prod @ozamani9gh @OlgaPotiagalova

bcgov / entity

COLIN Sync - Incorrect COLIN filing type used for alteration filing synchronization (BC to Benefit). #19528

COLIN Sync supported alteration filings: