bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

COOPS-UI: update to latest common components #1984

Closed severinbeauvais closed 4 years ago

severinbeauvais commented 4 years ago

Description:

Coops UI is using an older version of the sbc-common-components and is therefore missing some fixes and new functionality.

I created this ticket because it's not as simple as updating the dependency version in package.json -- since other common components may have changed, the coops-ui code may need to be updated also. In particular, the following need to be tested:

Dependencies This ticket is all about Coops UI using the latest sbc-common-components dependency.

Acceptance Criteria

Validation Rules See AC.

Ready for Sprint (DoR)

Ready to Build, Story level (DoR):

Acceptance / DoD:

WaldemarSchneider86 commented 4 years ago

~~Severin mentioned 2019-12-23 that it is not critical not to be in Release Jan. 10. Will be done later. Agreed w. team in "Team Sprint Review". ~~

Update by SB: Cameron and I have decided to repurpose this ticket (and I have already updated the description accordingly) and are planning to include it in the forthcoming release (2.4.0 on Jan 10).

severinbeauvais commented 4 years ago

Quick status update: coops-ui was using sbc-common-components v2.0.22. Now we want to use v2.0.30. However, about a third of our Jest unit tests report an error transpiling the code in the new version. (I found that v23 is fine but when I update to v24 the tests break.) So far I have not been able to determine any real difference between v23 and v24. Cameron said he'd have a quick look at it.

NB I have checked in some package dependency updates (and corresponding lint fixes) in this branch: https://github.com/severinbeauvais/lear/commits/1984.

severinbeauvais commented 4 years ago

Cameron fixed the Jest issue and will be PRing the changes for this ticket.