Closed arlentees closed 1 month ago
Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett
Ready for UXA: https://bcregistry-assets-dev--pr-1781-42g99fcg.web.app @saragunnarsson
Hey @dimak1 ! Here yo go, just a couple notes below (they apply to both transport permit types):
"Note: If the home has already been moved without a permit, a change of location cannot be completed online. You must notify BC Registries of the new location by submitting a Registered Location Change form)"
On review and confirm:
Thanks @saragunnarsson , updated: https://bcregistry-assets-dev--pr-1781-42g99fcg.web.app
@dimak1 Just noticed 2 things with that paragraph that got added..otherwise it seems great!
@saragunnarsson thanks for verifying, I will update and let you know.
Updated and ready for QA.
Hey @saragunnarsson @dimak1 , question for you when there is a PPSA Lien on a home, then the warning message displays same as the other Liens. Is that expected? Can you please take a look and confirm, thanks!
MHR 108011 in DEV has a PPSA Lien
MHR Info screen:
Also noticed that this registration does not has access to file transfer of ownership:
MHR 107998: Maintenance Lien
Design:
Hi @chdivyareddy - Oh nice! you caught some good inconsistencies there. I’m a bit of newbie on liens, but looking in figma it looks like if there is a PPSA lien then there should be a yellow alert and an active 'change ownership' button/link. For all other liens with a red alert, the buttons seems to be disabled, but not removed (for QS).
Hi @chdivyareddy @saragunnarsson want to address two point you made, PPSA and 'Change' owners button:
@LizGovier, just to recap our discussion, we want to update the Important message to be yellow, and remove the 'Change' ownership button from designs.
As a comment, for non staff the MHR API lien check prevents permit registrations if the existing PPR registration type is:
Hey @dimak1 @chdivyareddy
Here is my feedback.
Let me know if there's anything I missed, or if you'd like to meet.
Thank you @LizGovier, I will update the warning message. The Change button is not showing already.
@LizGovier, the Figma is not updated with the yellow warning message. cc: FYI @chdivyareddy
@LizGovier @chdivyareddy I added the following two messages for SBC: one for PPSA only and other default. PR is pending. Preview: https://bcregistry-assets-dev--pr-1785-n58herbf.web.app/
@chdivyareddy ready in DEV
Hey @dimak1 , found couple things here, please let me know if we need a separate ticket for these, thanks!
[ ] Days to expiry displays 29 days instead of 30 days from the date of filing:
[ ] Email address and phone number details are not displayed in the outputs for Transport permits and Amendments:
After dashboard is reloaded:
@chdivyareddy @dimak1 the days to expiry is an API issue specific to DEV which is now post data migration. There was no submitting party phone number or email submitted to the API for the 108011 transport permit or amendment to a transport permit. I will also check if the DEV API immediate response for the report availability is the same as TEST (pre data migration).
@chdivyareddy the first two items are related to API (exp days are coming from API, also the output). The third issue I need to look into.
@dimak1 from my previous comment, I do not think item 2 missing submitting party email and phone number is an API issue.
@dimak1 @doug-lovett , here is the ticket for the issue with Phone number and email address for SBC users which was already created #20199 and noted it was a UI issue, thanks!!
@chdivyareddy For item 3, I see no API difference pre-migration/post-migration in setting the report availability for the account registrations table. However, the API post migration performance in DEV is relatively faster so a few seconds difference in fetching the registrations summary information may explain why the DEV table is not showing the report as immediately available. Also, the report service container goes to sleep after a period of inactivity, and the next request has an additional 4-5 second lag. This behaviour occurs frequently in DEV and TEST.
Good Morning @doug-lovett , I tried this morning in both Staff and SBC account and tried multiple times to generate the report, but couldn't. So, I have been waited for more than 5 mints and still the issue looks the same. Earlier, in the staff account the registration report generation was quick after the submission. Also noted that for both the staff and SBC account, the base registration displays i icon when there is a username.
Staff:
SBC:
@chdivyareddy in DEV no reports are available prior to March 18, 2024. As staff I see in the UI that recent registrations are showing reports as available. I will look into if change registrations on legacy registrations are not showing the reports as available. As brtest1 in DEV I just downloaded the transport permit for 108292.
@chdivyareddy as brtest5 account id 2829 in DEV from the UI I just downloaded the permit for 107994 doc reg number 00550272. Report 2024-03-20_BCMHR_Registration_107994.pdf
Hey @doug-lovett , Yes I was able to download the reports as well in DEV, only when I reload the dashboard, but i think I should be able to download when I click on the i icon after submitting the filing for few seconds, that's how it used to work earlier in the UI. If not, we need to inform the users to reload the dashboard once the filing is done?
@chdivyareddy @doug-lovett fixed the submitting party for SBC users. The issue was that the submitting party was coming from the account info, and not the one filled out in the Submitting Party form on the Review step (PR pending).
@chdivyareddy @doug-lovett
For the PDF icon/download issue. When MHR Table if loaded after the submission, the path
value is empty, therefore the PDF download link is not available. That's why it only appears after the reload. I submitted MHR 108100.
After the Transport Permit filing
The path
in the payload is empty
Verified in DEV for the email & phone number issue for SBC users in the outputs and working as expected.
Transport Permit:
Amendment:
@chdivyareddy, thanks for verifying.
For the PDF download link, maybe we can open another ticket to investigate further. But from the looks of it, the path
to download file is not available, hence the UI is letting you download it. cc: @doug-lovett
@dimak1 @doug-lovett , Here is the new ticket created for the report generation issue #20413, thanks!!
Service BC should have access to file Transport Permits and Amend Transport Permits through the modernized BC Registries system.
Figma Design
Service BC have the same access as a General User (Dealership).
Our review has confirmed that General User (Dealership) is slightly different since they cannot request a Transport Permit if a tax certificate is required. General User (Dealership) can only amend a transport permit they have created.
SBC Flow (as currently in BCOL) - The flow should be similar as for Lawyers/Notaries:
[x] No DocumentId captured (automatically generated by system)
[x] Update Location Change dropdown to remove 'Registered Location' as per Figma
[x] Submitting Party:
Remove PPR Auto populate component. Submitting Party is manually entered (usually owner, agent or service provider/lawyer)
Update description text for Submitting Party
[x] Updates to Fee Summary - Reads as is in Design. No payment captured (client pay up front, and not captured in system) Should work similar to PPR.
[x] Restricted if PPR like QS (Lawyer/Notary), they need to refer to staff Registry when there is a Lien.
Note: In terms of transport permit, there is there is a difference between Qualified Suppliers types: Lawyers/Notaries, Dealers, and Manufacturers. Dealers and Manufacturers have restrictions for issuing transport permits for MHRs that they own/on their lot, and Lawyers/Notaries can issue a transport permit for any MHR (with some PPR and some Unit notes restrictions). SBC is using the same flow as Lawyers/Notaries.