Open peter-freshworks opened 4 years ago
Hi Emmanuel. This is a new ticket, created to finish some work which disabled some validation temporarily. IMO it is not high priority (because no critical functionality is broken) but it should be done in the current or next sprint. Please triage accordingly. Thanks!
Thanks Severin. I will bring this ticket up for Kaine's consideration for sprint 20
@peter-freshworks are you working on this and does it need to be merged or reviewed still?
In Pull Request 521, the business addresses structure changed from
to
In the subject PR, the necessary schema changes were made to the Change Of Address JSON schema, but they were not made to the Annual Report JSON schema; indeed, for AR validation to pass, the 'mailingAddress' and 'deliveryAddress' fields were changed to "not required". Hence, the AR JSON schema is broken (it fails to require/validate addresses).
This ticket, then, is to finish the Annual Report JSON schema changes, including:
(These are basically the same changes made to the Change Of Address JSON schema.)