search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Staff user cannot edit "Update Business Profile" #2017

Closed riyazuddinsyed closed 4 years ago

riyazuddinsyed commented 4 years ago

Describe the bug When a staff is entered with an IDIR Login and in the dashboard page when the user tries to "UPDATE BUSINESS PROFILE",then the "API throws 403 FORBIDDEN ERROR" and is not handled in the UI prospective.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://dev.bcregistry.ca/cooperatives/auth/signin/idir'
  2. Click on 'UPDATE BUSINESS PROFILE'
  3. Enter the "CONTACT INFO"
  4. See error

Expected behavior Either the staff should be able to edit the "BUSINESS PROFILE" or the page should be disabled. Else the UI should throw the validation error.

Screenshots Capture1.PNG

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

JohnamLane commented 4 years ago

This is still an issue, same with "Edit Profile" as staff.

severinbeauvais commented 4 years ago

@Kaineatthelab Should staff be able to go to the Update Business Profile page, or should this be blocked? If the former then this is likely a Relationships issue. If the latter then the Entity team can implement the necessary change, Thx!

Kaineatthelab commented 4 years ago

Yes staff should have cart blanche in most cases.

Kaine Sparks Director, Digital Operations| BC Registries and Online Serviceshttp://www.bcregistryservices.gov.bc.ca/ Service BC Ministry of Citizens’ Services T: 250-415-3957 | Web: http://www.servicebc.gov.bc.cahttp://www.servicebc.gov.bc.ca/ “Access to government services made easy”

From: Séverin Beauvais notifications@github.com Sent: January 8, 2020 1:58 PM To: bcgov/entity entity@noreply.github.com Cc: Sparks, Kaine CITZ:EX Kaine.Sparks@gov.bc.ca; Mention mention@noreply.github.com Subject: Re: [bcgov/entity] Staff user cannot edit "Update Business Profile" (#2017)

@Kaineatthelabhttps://github.com/Kaineatthelab Should staff be able to go to the Update Business Profile page, or should this be blocked? If the former then this is likely a Relationships issue. If the latter then the Entity team can implement the necessary change, Thx!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/bcgov/entity/issues/2017?email_source=notifications&email_token=AIRHOIMNABBMEDVXTGW5JRTQ4ZD5BA5CNFSM4JTDQEY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIOD54Y#issuecomment-572276467, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIRHOIKXCN3H3KU5R26VIK3Q4ZD5BANCNFSM4JTDQEYQ.

JohnamLane commented 4 years ago

Should be handled by 1856. I linked them.

JohnamLane commented 4 years ago

Current state suggests this can be closed now: