Investigate - Name Examination Vue 3 - - MAINTAIN FILTER STATE WHEN NAVIGATING AWAY

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 59 forks source link

Investigate - Name Examination Vue 3 - - MAINTAIN FILTER STATE WHEN NAVIGATING AWAY #20339

Closed semmatti closed 4 months ago

semmatti commented 8 months ago

Search screen defaults to Hold, whereas some examiners prefer for it to remain static on a previous request type they had selected (such as Priority/Standard), because some examiners like to reference the search field when they suspect there may be upcoming duplicates.

Clarify with examiners if there should be an option to toggle between the current behaviour and the requested behaviour.

Please confirm with examiners whether to keep filters or clear filters when navigating away from search.

oanyahuru commented 8 months ago

The examiners would like if they could have the ability to freeze their choices/their filter selections. Or let the user toggle to freeze or not freeze a set of selections. Otherwise, it would be nice to have it default to last settings.

rstens commented 5 months ago

@ozamani9gh This now needs to be a new ticket in the backlog. Nothing to QA Here

flutistar commented 5 months ago

@rstens Sorry for missing the description. On Name Examination Search page, we have several dropdowns. When we re-visiting this page, we need to set those dropdowns every time to filter NRs.

So I implemented local storage to persist dropdown filters and now whenever we visit(or even refresh), it's populating dropdown choices from local storage. It means, they(examiners) don't need to set filters every time.

Let me know if I missed anything.

Thanks

rstens commented 5 months ago

Your unit tests are failing: please run npm run test and fix the issues @flutistar

flutistar commented 5 months ago

Before creating PR, I ran npm run test and all the cases were passed. @rstens

rstens commented 5 months ago

Unit tests are fine now: Learning point - run them with WSL

rstens commented 5 months ago

Verified in DEV and TEST.

EPortman commented 5 months ago

This caused text input fields to stop working. Made text input fields into v-models for 2-way binding.

EPortman commented 5 months ago

These need to be rolled out together https://github.com/bcgov/name-examination/commit/572eda4c46b76057ab2029f1b36b213e451f8909 https://github.com/bcgov/name-examination/commit/45f78d55927e22d1097e637ed416e53c05beff53

EPortman commented 5 months ago

This is now in test.

EPortman commented 5 months ago

State is remembered when page is refreshed or navigating away.

Toggle tickets in DRAFT status
Go to Stats
Go back to Search
Tickets are still filtered in DRAFT status ** The above behavior is for all dropdown fields

Text Inputs now search for matching letters as they are typed.

Modified by
NR Number
Names
Applicant First Name
Applicant Last Name

Mihai-QuickSilverDev commented 5 months ago

[ ] A specific configuration of Priority Queue and Classify words:
Does not get saved when refreshing the page using F5.
They do get preserved when clicking Get Next and moving to another NR.

ozamani9gh commented 5 months ago

@flutistar can you please fix Mihai's test cases that failed. thanks

Mihai-QuickSilverDev commented 5 months ago

[ ] While we don't have to care about Classify Words in the future, the persistence of the Priority Queue setting was not fixed.
[ ] Moving this ticket back to Sprint Backlog.

flutistar commented 4 months ago

This was fixed on both DEV and TEST. Here are the URLs that I used:

@Mihai-QuickSilverDev @ozamani9gh

Mihai-QuickSilverDev commented 4 months ago

[ ] Confirmed fixed. Moving to Ready for Release.