Open ozamani9gh opened 8 months ago
We have a notification_history
table, but it does not store the email body. The email body needs to be regenerated based on the information we have. Here are the notification types and their required parameters:
Currently, I believe the problem is retrieving emails sent before NR renewal—the previous expiration dates need to be retrieved from the log. Additionally, the current notify-api does not support retrieving specific NR data from the notification_history table. I will open a ticket with the SRE team. Finally, displaying the email body in the UI is also a challenge. New functions will need to be created to ensure the email body appears in the UI. -- I wonder if it is possible to display only the parameters used to generate the email in the UI, instead of the entire email body?
The UI design looks great. However, considering the implementation, is it possible to make some changes?
We don’t store the body of emails. To display the entire email in the UI, we would need to generate the email on the fly, and the email template is in the entity-queue project, which is better left untouched at this level. Instead, could the notification histories be displayed as a list with columns such as:
Additionally, I have concerns about retrieving historical data after edits. For example, if we resend a receipt after updating names, the NR name information in the receipt will reflect the current name information instead of what was in the original receipt. Is this acceptable?
@eve-git I have reached out to the design team on your first question above. I have also contacted the examiners for their comments on the second point. I will keep you posted
Support required from other apps:
@eve-git the design team has proposed a new design
The business also responded to your second question
Namex has an events table. I am considering saving the NR states before sending the notification. The notification can then be retrieved by sending the NR states to the entity-emailer. I will discuss this possibility with the entity developer
request the support from emailer to accept NR object as parameter: https://github.com/bcgov/entity/issues/21632 https://app.zenhub.com/workspaces/entities-team-space---new-65550db1fcfd2f002838a52a/issues/gh/bcgov/entity/21632
For Each Notify record build a button to be able to resend email.
https://www.figma.com/file/zHZFygfAWSmNp6kDb7g1Zs/NameX-Design-Tickets?type=design&node-id=2-25&mode=design