bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Investigate - COLIN UPDATER - BCROS Sending incorrect date to COLIN #20834

Open ozamani9gh opened 4 months ago

ozamani9gh commented 4 months ago

Investigate BCROS sending over an incorrect LAST AR FILED DT to COLIN. https://app.zenhub.com/workspaces/ops-60f8556e05d25b0011468870/issues/gh/bcgov-registries/ops-support/3779

There are two issues here:

(1) data fixing the data on the home team side. @schaturv18 indicates that he already has run this update, but I have asked Darci to check the data; and

(2) fixing the data sync from BCROS to COLIN/CPRD. Darci and David Roberts have shown that, for AR filings, BCROS is sending incorrect data that is landing in the LAST_AR_FILING column in the CPRD database tables. BCROS is sending over the Filing Date (Date and Time that the last AR was filed). However, the data home team should be getting is the company's recogition date (month and year), plus the year of the annual report.

So: if a company was incorporated on January 14, 1990 and is filing its 2024 annual report today, the LAST_AR_FILED_DT should be recorded as 2024-01-14 00:00:00 - not as 2024-04-11 (today's date).

stevenc987 commented 3 months ago

@ozamani9gh @rarmitag

I saw you guys mentioned that It was not worth to investigate/fix for this syn issue anymore. Is it right? Please see what you discussed below:

image.png
rarmitag commented 3 months ago

@stevenc987 - In the past when there were only a few updates a week it wasn't worth it, but now it's being updated because other issues have started to show, covered by other tickets, plus a need to ensure that the sync works for LTD's when they move into LEAR The LTD sync is really the driving force which is new.

vikas-gov commented 2 months ago

Fixed by #21633. Naveen to review and confirm