bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

BUG - Validation on Declared Value and Consideration amount if Zero #20933

Closed arlentees closed 4 months ago

arlentees commented 6 months ago

In all cases of transfers, the Declared Value of Home and Consideration field must have a minimum value of $1.

Currently, a value of 0 is accepted in the UI, even though the user is eventually unable to register and pay.

The expected result is that if a value of 0 (or no value) is entered, an error message is presented to the user explaining the value must be a minimum value of 1.

Notes:

Figma Design

LizGovier commented 6 months ago

@fareenr Could you confirm that this if a rule for the Declared Valued and Consideration amount.

LizGovier commented 6 months ago

Note as per Cameron's comment

Only allow numbers, and validate the minimum amount - might also require another input field if allowing consideration descriptions is a hard requirement.

Adding a second input field for consideration description could still result in a user adding a text input of 'Zero' (highly unlikely, but...)

@arlentees Before we put the work in, it would be worth finding out why this business rule is in place.

arlentees commented 6 months ago

On hold pending a regulations/design/requirements review of the above questions

doug-lovett commented 6 months ago

Here is a prod sample of active registrations with active owners where the consideration is text (MHR's starting with 08).080224 $1.00 AND FAMILY CONSIDERATION 080230 $10000.00 (INCLUDES THE PURCHASE OF THE LAND) 080265 $1.00 UNDER SEPERATION AGREEMENT 080348 $1.00 AND NATURAL LOVE AND AFFECTION 080421 $1.00 AND NATURAL LOVE AND AFFECTION 080441 ONE HUNDRED EIGHTY NINE THOUSAND FIVE HUNDRED 080486 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION. 080532 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 080535 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 080706 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 080792 NINETY-FOUR THOUSAND FIVE HUNDRED DOLLARS 080878 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 080954 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 081034 $1.00 AND OTHER GOOD & SUFFICIENT CONSIDERATION 081097 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 081116 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 081280 NINETY FIVE THOUSAND 081340 FIFTY FIVE THOUSAND DOLLARS 081351 $1.00 AND ALL OTHER GOOD AND VALUABLE CONSIDERATION 081356 FIVE THOUSAND 081423 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 081504 FIFTY THOUSAND DOLLARS 081731 $75000.00 OTHER GOOD AND VALUABLE CONSIDERATION 081759 1.00 AND NATURAL LOVE AND AFFECTION 081769 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 081791 10.00 AND ALL OTHER CONSIDERATION 081808 ONE ($1.00) DOLLAR 082001 1.00 AND NATURAL LOVE AND AFFECTION 082031 ONE HUNDRED AND NINETEEN THOUSAND DOLLARS 082117 $1.00 AND NATURAL LOVE AND AFFECTION 082140 THIRTY-FIVE THOUSAND 082164 $1.00 AND OTHER VALUABLE CONSIDERATION 082264 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 082274 TWO HUNDRED NINETY SIX THOUSAND FIVE HUNDRED DOLLARS 082395 $1.00 AND NATURAL LOVE AND AFFECTION 082502 $1.00 OTHER GOOD AND VALUABLE CONSIDERATION 082556 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 082631 $0.00 (NATURAL LOVE AND AFFECTION) 082656 $1 AND OTHER GOOD AND VALUABLE CONSIDERATION 082874 $1.00 AND ALL OTHER GOOD AND VALUABLE CONSIDERATIONS 082987 SIXTY-SEVEN THOUSAND DOLLARS 083186 $1.00 AND NATURAL LOVE AND AFFECTION 083190 TWENTY FOUR THOUSAND FIVE HUNDRED 083249 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 083267 1.00 AND NATURAL LOVE AND AFFECTION 083287 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 083320 SIXTY-NINE THOUSAND DOLLARS ($69,000.00) 083380 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 083439 $1.00 AND NATURAL LOVE AND AFFECTION 083579 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 083599 1.00 AND OTHER VALUABLE CONSIDERATION 083694 $1.00 AND PURCHASE OF LANDS 083740 1.00 AND NATURAL LOVE AND AFFECTION OF HUSBAND TO WIFE 084011 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 084045 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 084054 $1.00 AND ALL OTHER GOOD AND VALUABLE CONSIDERATION 084184 $1.00 AND NATURAL LOVE AND AFFECTION 084185 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 084343 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 084699 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 084969 1.00 AND LOVE AND AFFECTION 085058 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085119 1.00 AND NATURAL LOVE AND AFFECTION 085209 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085272 1 AND OTHER VALUABLE CONSIDERATION 085316 $1 AND OTHER GOOD AND VALUABLE CONSIDERATION 085356 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085439 TWO HUNDRED AND FORTY-SEVEN THOUSAND, EIGHT HUNDRED DOLLARS 085504 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085563 1.00 AND NATURAL LOVE AND AFFECTION 085605 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085687 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085797 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085823 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085908 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 085949 TWENTY THOUSAND THREE HUNDRED AND TEN DOLLARS 085952 1.00 AND OTHER CONSIDERATION 086016 $1.00 AND NATURAL LOVE AND AFFECTION 086095 $1.00 AND NATURAL LOVE AND AFFECTION 086242 $1.00 AND OTHER CONSIDERATION 086251 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 086287 TWO HUNDRED TEN THOUSAND 086388 $1.00 AND OTHER VALUABLE CONSIDERATION 086473 1.00 AND OTHER VALUABLE GOODS 086556 TWO HUNDRED AND THIRTY-FIVE THOUSAND 086585 1.00 AND GOOD AND VALUABLE CONSIDERATION 086812 1.00 AND ALL OTHER GOOD AND VALUABLE CONSIDERATION 086946 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 086960 $1.00 AND GOOD AND VALUABLE CONSIDERATION 086991 $1.00 AND NATURAL LOVE AND AFFECTION 087152 $1.00 AND NATURAL LOVE AND AFFECTION OF WIFE TO HUSBAND 087184 $1.00 AND NATURAL LOVE AND AFFECTION 087206 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 087346 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 087360 $1.00 BILL OF SALE 087378 $1.00 AND SETTLEMENT OF PROPERTY 087617 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 087620 TWO HUNDRED THIRTY FIVE THOUSAND DOLLARS 087625 FIVE HUNDRED FIFTEEN THOUSAND 087658 OTHER GOOD AND VALUABLE CONSIDERATION 087725 $1.00 AND NATURAL LOVE AND AFFECTION 088014 FIFTY THOUSAND FIVE HUNDRED SEVENTY THREE DOLLARS FIFTY CENTS 088109 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 088137 $75000.0075000 088346 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 088363 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 088400 THREE HUNDRED NINETY-FOUR THOUSAND DOLLARS 088587 $315,000.00 (WHICH INCLUDES MHR 88587 AND 100 SHARES IN 451620 BC LTD.) 088650 $1.00 AND OTHER GOOD & VALUABLE CONSIDERATION 088706 FIFTEEN THOUSAND ($15,000.00) DOLLARS 088734 1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 088771 1.00 AND NATURAL LOVE AND AFFECTION 088850 EIGHTY-SEVEN THOUSAND FOUR HUNDRED FIFTY-FIVE DOLLARS NO CENTS 088851 TWO HUNDRED THIRTY FIVE THOUSAND DOLLARS 088852 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 088947 1.00 AND ALL OTHER GOOD AND VALUABLE CONSIDERATION 089014 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089016 ONE HUNDRED FIFTEEN THOUSAND, ONE HUNDRED THIRTY-FIVE DOLLARS 089019 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATON 089063 ONE HUNDRED SIXTY NINE THOUSAND DOLLARS 089114 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089126 ONE DOLLAR ($1.00) 089167 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089172 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089248 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089301 $1.00 AND ALL OTHER GOOD AND VALUABLE CONSIDERATIONS 089303 $1.00 AND SETTLEMENT OF PROPERTY 089482 FIFTEEN THOUSAND DOLLARS 089541 ONE HUNDRED TWENTY FOUR THOUSASND, EIGHT HUNDRED AND EIGHT.....25/1000 089632 $1.00 AND OTHER CONSIDERATIONS 089657 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089675 ONE HUNDRED AND FOUR THOUSAND THREE HUNDRED AND FORTY EIGHT 089782 $1.00 AND NATURAL LOVE AND AFFECTION 089866 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089937 $1.00 AND OTHER GOOD AND VALUABLE CONSIDERATION 089996 FIFTY SIX THOUSAND NINE HUNDRED TWENTY-NINE

LizGovier commented 6 months ago

Sharon's response: Verbiage from the manual: “A transfer must contain a selling prices or “consideration”. A token consideration e.g. $1.00 or “Natural Love and Affection” is acceptable with 2 exceptions.

First the document must set out what the consideration is – not what it isn’t unless a “personal seal” is used. It could not therefore say $0.00 or “No consideration” unless a “personal seal(s)” were applied near the signature. These usually appear as round red stickers approximately 3/8” in diameter. No consideration is necessary when a personal seal is used. These seals are rare and considered outdated.

The second exception involves a transfer from an executor to a buyer. See transfers from executors page

Transfer from an Executor(rix)

Examiner reads the Will. If the Will provides that the home goes to “A”, and executor is transferring it to “A & B”, executor must submit sworn statemen declaring that the written consent has been obtained from “A”.

An executor may not distribute any portion of the estate to a beneficiary within 6 months of the date of probate unless “all persons entitled to apply under the Wills (Variation) Act have consented to the transfer” and the executor’s sworn statement is submitted to this affect, or a court order has been obtained.

….”in the transfer document, a token consideration may be used, or a recital included explaining that the transfer is distributing the estate or a portion of it”


Sharon: I think it would be better if the system flagged a $0.00 value at the time they entered this- to ensure that if a $0.00 is entered, they must have >>>”blah”.

Right now the system pulls the declared value into the consideration value field.. if they input $0.00 here because they think they are going to populate the consideration value.. they get an “unable to complete” error message without any information as to why. The declared value field should always have a value in it and the consideration would need to be overridden.

I would really like to make this more clear in the application and it should be giving a “red” error message at the declared value field if they put zero dollars or bypass it.

LizGovier commented 6 months ago

@arlentees

I'm wondering if we can, at the minimum, add a rule that if the exact value = '$0' or '$0.00" and nothing else, show error validation.

arlentees commented 6 months ago

@LizGovier I'm thinking the same thing - show an error if value is empty, "0", "0.00", and if possible, check against "zero", "nothing".

arlentees commented 5 months ago

also acceptable is “in consideration of love and affection”

LizGovier commented 5 months ago

hey @arlentees

Would it be ok to move forward with showing an error if the value is empty, "0", "0.00", and if possible, check against "zero", "nothing". Or are we waiting for more information from staff or Policy?

arlentees commented 5 months ago

@LizGovier I don't think we're waiting for any more information - so it's up to devs to validate based on it being not empty or a value of zero.

chdivyareddy commented 4 months ago

Hey @cameron-eyds , Declared value validation looks good, but the Consideration field validation is not as expected. Please take a look, thanks!

Review screen:

Screenshot 2024-06-12 at 10.29.21 AM.png
cameron-eyds commented 4 months ago

@chdivyareddy Morning Divya, unfortunately this is as expected. This field is a text field and once we start adding other special characters or spacing it will go outside the validation checks we've put in place.

As per designs, this is basically what we are validating.

Screenshot 2024-06-12 at 11.07.10 AM.png
cameron-eyds commented 4 months ago

@chdivyareddy Found a small issue with the added rules, when you open a Frozen MHR that requires a Sale or Gift, has a field pre-populated. It triggers a part of the validation rules it shouldn't and errors out. I have fixed this in the PR for 21433! Soon soon just a heads up :)

chdivyareddy commented 4 months ago

@cameron-eyds , thanks for the heads up:)

cameron-eyds commented 4 months ago

No prob! Fix is already in DEV so you can probably ignore me :)