bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

UI - Updates to framework for Individual Form #20982

Closed mstanton1 closed 5 months ago

mstanton1 commented 6 months ago

Figma: https://www.figma.com/file/4oi1IWHe0DmbY8EZk3Srs3/Add%2Fedit-SI?type=design&node-id=200%3A10521&mode=design&t=5phLqqfvNcYyqrWk-1

J-Baese commented 6 months ago

@hfekete couple of spacing issues with the section headers (in general) - it's feeling a bit tight, can we make the spacing like this?:

image.png image.png

And then with the larger sections that have a header the corners of the white box should be rounded at the top but then no radius in the subsequent inner sections until the bottom image.png

image.png
J-Baese commented 6 months ago

@hfekete just noticed this weird spacing happening also with the button running into the top of the form: image.png

And i assume that the date of significance will get moved when you update that component?

gunanagar commented 5 months ago

Tested in Test Environment @hfekete There are couple of text mismatching in UI which is listed below. 1.Place holder text in email address field is not as per the design

Screen Shot 2024-05-27 at 4.18.06 PM.png

Design

Screen Shot 2024-05-27 at 4.19.08 PM.png

2.Address label text is not as per the design

Screen Shot 2024-05-27 at 4.22.19 PM.png

Design

Screen Shot 2024-05-27 at 4.24.07 PM.png
  1. Canada Revenue agency label is not moved to left as per the design Screen Shot 2024-05-27 at 4.26.58 PM.png

    Design

    Screen Shot 2024-05-27 at 4.27.54 PM.png
hfekete commented 5 months ago

Texts will be updated in the #20840 as they were being changed while the tickets were being worked on. If you dont mind adding discrepancies to the mentioned ticket that would be great !! Thank you!

gunanagar commented 5 months ago

Updated into ticket #20840. Closing this ticket