Namerequest UI: wrong legal type while creating a Continuation In numbered company

[riyazuddinsyed]

Describe the bug in the current situation When the user tries to create a numbered Continuation In filing then the 401 unauthorized error shows up and in the legal APi Draft response the legal type is wrong.

Steps to reproduce the behavior:

1. Go to 'https://dev.bcregistry.ca/business/'
2. Login with BCREGA001/98900001
3. Navigate to NR and create a Numbered Cont In
4. Upon hitting on Incorporate Now the UI throws an Invalid filing error.

Screenshots/ Visual Reference/ Source

[severinbeauvais]

@OlgaPotiagalova We will need to pull in this bug ticket soon. (Maybe it can wait until next sprint.)

[severinbeauvais]

I quickly investigated this bug and found that the list of business types for Continuation In uses the wrong entity types. I believe the following dialog is correct:

But the code are wrong:

The correct codes are C, CBEN, CCC, CUL, etc.

[OlgaPotiagalova]

@severinbeauvais please go ahead with the ticket if it needs to be fixed this sprint to ensure progress. Thank you

[severinbeauvais]

IGNORE THE FOLLOWING TEST NOTES, WHICH APPLIED TO AN INITIAL (NOW ABANDONED) SOLUTION. SEE NEW TEST NOTES BELOW.

~Test Notes~

~Since this bugfix touches common code, the entity lists should be verified, for example the "New Business" list of entities:~

~The main fix, of course, was to the entity list for continuation in NRs:~

short list

full list

~What you can't tell from these lists is which entityType is assigned to each type of entity for a NR. The way to test this is to create NRs of each type, for each entity type, and looking at the raw data in the Dev Tools Network tab.~

~Specifically, for a New Business NR, the entityType values should be CR, BC, CC, and ULC.~

~Specifically, for a Continuation In NR, the entityType values should be C, CBEN, CCC, CUL (and also CP for coops and CS for socities).~

~The final test is to verify that the reported bug is fixed -- you are able to create numbered Limited Company Continuation In applications from Namerequest UI.~

~I have tested the above locally.~

[severinbeauvais]

New Test Notes

A simpler solution was implemented, which only sets the correct entity type (eg, C/CBEN/CCC/CUL) when a numbered Continuation In draft is created.

For a Continuation In NR, the previous code was unchanged. (In this case, Namex API populates the correct entity type.)

Specifically, please verify:

• a NEW name or numbered business can be started (regression test)
• a Continuation In (names or numbered) can be started
• the initial short list contains only Limited and Unlimited
• the tooltips in the entity type list/dialog are correct
• selecting "Society" shows a dialog with a link to navigate to Societies Online

I have verified the above locally and on the PR preview site.

[severinbeauvais]

@ozamani9gh @stevenc987 Please tag this ticket to your next Namerequest UI release. It would be nice to have this in Test but no rush to get it into Prod as it's disabled by feature flag for now anyway.