bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

FIX - Entity type for new Societies NR set to Null #21053

Open oanyahuru opened 4 months ago

oanyahuru commented 4 months ago

This was noticed while testing #20142 yesterday towards the afternoon. Prior to that, the error did not appear. It is also occuring in prod and leading to some confusion for clients. When a new NR for a society is created, it appears that the entity type for the NR is set to null instead of SO for society.

image.png

This ultimately results in errors when the letters are being generated, for next steps the users are being directed to Forms

image.png

They should instead be directed to Societies

image.png
ozamani9gh commented 4 months ago

https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/20142

ozamani9gh commented 4 months ago

@oanyahuru can you confirm this is still an issue.

EPortman commented 3 months ago

Not able to recreate this issue.

In NameRequest UI, to make a societies NR one must leave the page to bcregistry.ca/societies. So NameRequest UI is not connected with Society NRs.

EPortman commented 3 months ago

Seems like this is an issue with the legacy app. Name Request properly sends _entity_type_cd to the API when submitting a NR which the API adds to database correctly.

It may be something like the legacy app is not sending the field correctly.

EPortman commented 3 months ago

Confirmed the API is working fine

ozamani9gh commented 3 months ago

@Mihai-QuickSilverDev can you reach out to Home Team. Fix needs to be applied there.

Mihai-QuickSilverDev commented 3 months ago

@MKagis @droberts27 Good Morning Michael, David, the issue described in this ticket was identified as pertaining to one of the Home Team Systems - hence I am forwarding it here to you. Please see details presented above. Please let us know if there is anything that the BCROS Team could provide for this issue. Thank you!

MKagis commented 3 months ago

@ozamani9gh @Mihai-QuickSilverDev @oanyahuru

A few questions from my end:

Mihai-QuickSilverDev commented 3 months ago

@oanyahuru Hi Oge, would you be able to comment on Michael's points above? Thanks much! @ozamani9gh

MKagis commented 3 months ago

Hi again,

Thayne and I have just done some testing on the societies side of things and we can see that the data is created in the legacy application and database just fine. For NR 5141584, we see REQUEST_TYPE_CD=SO in the legacy database. Therefore, the described issue is not a problem with the legacy application, Societies Online, but with how the data is transferred to the modern infrastructure.

This situation makes the answers to my questions about when this issue started even more important. The home team has not make any changes to how NRs are created. Have there been any changes to the modern databases or to process that syncs the data to modernized infrastructure? There is no data problem on the legacy side.

fodiley commented 3 months ago

@oanyahuru , @Mihai-QuickSilverDev , @ozamani9gh If tickets still need to be reviewed can we not move them to done. It was in the done column this morning. Can we have the person who is to review to this ticket do so

fodiley commented 3 months ago

@MKagis this was moved to done by the PO Omid in error because our coop told us it was done. We will be reviewing this ticket and see how it can reviewed.