bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

Submission for Remaining Staff Transfer Flows #21076

Closed arlentees closed 4 days ago

arlentees commented 2 weeks ago
dimak1 commented 1 week ago

Hi @doug-lovett I found a small discrepancy for one of the transfer types. The document codes do not match:

In API spec: Transfer document types with a bill of sale: TRANS_WRIT_SEIZURE (Transfer Due to Writ of Seizure and Sale)

In the Transfers Requirements - All Transfer Types spreadsheet: TRANS_WRIT_POSSESSION - Transfer Due to Writ of Seizure and Sale

doug-lovett commented 1 week ago

@dimak1 good catch, the API spec is correct, the spreadsheet should be updated to TRANS_WRIT_SEIZURE. The new document type codes came from me.

dimak1 commented 1 week ago

Thanks @doug-lovett, I will update in the code. @LizGovier please update the spreadsheet.

LizGovier commented 1 week ago

@dimak1 Updated. https://docs.google.com/spreadsheets/d/11gLZJdBmhJRun69bTC08ticO2Vnjm9be/edit#gid=1494155514

chdivyareddy commented 1 week ago

Hey @dimak1 , the submissions for all the misc transfer types and the filtering worked as expected in DEV except the "Transfer Due to Court Order" has 'No Fee' in the requirements doc, but in the UI displays $50.00, please take a look, thanks!!

image.png
dimak1 commented 1 week ago

Good catch @chdivyareddy, thank you. I fixed it and PR is under review now.

dimak1 commented 6 days ago

Ready in DEV.

chdivyareddy commented 6 days ago

Verified in DEV!

image.png image.png
chdivyareddy commented 4 days ago

Submissions worked as expected in TEST, but there is issue with filtering from MHR table in TEST, will create a ticket for it, moving this ticket along for now.