bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

Remove -Refresh F5 - Output Page - Hide Documents #21122

Open NaveenHebbale opened 2 weeks ago

NaveenHebbale commented 2 weeks ago

OCM suggestion to Remove Hide Documents from UI

image.png
severinbeauvais commented 2 weeks ago

@yuisotozaki FYI

yuisotozaki commented 2 weeks ago

Makes sense to me!

severinbeauvais commented 1 week ago

The button needs to exist because this ledger entry is an expanded list item (which needs to be expanded or contracted).

How about this?

image.png

The code change (line 15):

image.png

Sample filing: http://localhost:8080/Ta08xzwyRK?filing_id=149112

yuisotozaki commented 1 week ago

Design team met on May 9 to review this design.

severinbeauvais commented 1 week ago

OK, we can implement a special case to remove the expansion toggle button altogether. We should also implement a special case that this type of filing is always auto-expanded (since, without the button, it cannot be expanded if collapsed).

As for why not wait longer? Mostly it's because the back end processes can sometimes get stuck (until we restart them). There is no "minimum wait time for BE to complete" value.

yuisotozaki commented 1 week ago

The design team's dream solution is to have the front time-out on the back end and have a purpose designed page to let the user know that a) the filing was submitted, b) something went wrong so we cannot display the result, and c) please check back later.

severinbeauvais commented 1 week ago

That's doable. What do you think the business page should look like during the delay period? How long should the timeout be? Is a modal OK to inform the user? What are the modal actions?

severinbeauvais commented 2 days ago

@ArwenQin @OlgaPotiagalova

I pre-assigned this ticket to Arwen.

Arwen, when you are finished your previous ticket (or if you are temporarily blocked on it and need more work), then move this ticket to In Progress.

Arwen, you and I need to chat about the requirements and how to satisfy them. It will be a bit exploratory to figure out the cleanest way to implement this but I will work through it with you.