bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

API Transport Permit Data Validation Manufacturer Civic Address Ignore Case #21185

Closed doug-lovett closed 6 days ago

doug-lovett commented 1 week ago

Ignore new location civic address street and city case when verifying manufacturer permit new location civic address matches the manufacturer record location civc address.

doug-lovett commented 1 week ago

@chdivyareddy deployed to TEST along with 21133.

chdivyareddy commented 1 week ago

Good Morning @doug-lovett !

Sorry, small confusion here...Is this to file a Transport Permit in the QS Manufacturer account? or Staff transport permit when filing with location type 'Dealers/manufacturer's lot'?

Currently I tried filing a Transport Permit in TEST using QS Manufacturer account (BCREG0051 - MHR QS Re-Approval Account: ID - 2246) with MHR 108186 and seeing the following error when submitting the request:

image.png
doug-lovett commented 1 week ago

@chdivyareddy the above is a legitimate error - the account id is not set up as a qualified supplier/manufacturer. This fix is for a manufacturer creating a transport permit.

chdivyareddy commented 1 week ago

@doug-lovett Thanks for confirming!

I tried using BCREG0064 (MHR User Account: ID - 2196) account in TEST using MHR 108098 and seeing the following error:

image.png
doug-lovett commented 1 week ago

@chdivyareddy that is also a legitimate error. The only address that will work is: 9500 JIM BAILEY ROAD KELOWNA BC V4V 1S5 CA

You submitted: "newLocation": { "address": { "street": "42-22740 116 Ave", "city": "Maple Ridge", "region": "BC", "country": "CA", "postalCode": "V2X 2X7" }, "leaveProvince": false, "taxCertificate": false, "dealerName": "Dealer abc", "locationType": "MANUFACTURER" },

doug-lovett commented 1 week ago

So the test is that lower/mixed case address street and city will also work: 9500 Jim Bailey Road Kelowna

chdivyareddy commented 1 week ago

@doug-lovett Ah..ok, my understanding was you could enter any new civic address irrespective of the existing civic address. Thanks for the info:)

Verified in TEST!

image.png