bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Name-Examination: An error show up after clicking Examine button #21593

Closed eve-git closed 2 months ago

eve-git commented 3 months ago

A new NR never been examined by a examiner. The error " This NR is being examined by nro_service_account" flashes up in banner after clicking "Examine" button.

The reason:

  1. the button action: @click="examine.claimNr"
  2. async function claimNr() {
        await updateNRState(Status.InProgress)
    } 
    ...
    async function updateNRState(state: Status) {
    nrStatus.value = state
    await patchNameRequest(nrNumber.value, { state: state })
    await fetchAndLoadNr(nrNumber.value)
    }

    in which the nrStatus.value updated to InProgress, and otherExaminerInProgress is true:

    otherExaminerInProgress = computed(
    () => !isCurrentExaminer.value && nrStatus.value === Status.InProgress
    )

    After NR retrieved and the nrStatus.value updated the 'DRAFT', which makes otherExaminerInProgress and Examination button takes action.

eve-git commented 2 months ago

PR: https://github.com/bcgov/name-examination/pull/1464

eve-git commented 2 months ago

PR: https://github.com/bcgov/name-examination/pull/1478

eve-git commented 2 months ago

Test: It is hard to see the error banner when name-examination runs normally. Just test to make sure the app runs good.

Mihai-QuickSilverDev commented 2 months ago

Confirmed the application is working okay. Worked with NR 8160629.