search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Filings UI: Outputs showing in t-number view #21658

Open yuisotozaki opened 5 months ago

yuisotozaki commented 5 months ago

Follow-up to bcgov/entity#21122

When incorporation application is submitted and the application goes into "FILED AND PENDING | PAID" state, outputs are showing up. See attached screenshot.

Not 100% sure what we should be showing in this partially completed state. Does it make sense to display the "Retrieve Business Information" button at this state?

image.png

Sample receipt that shows the "T" number in the header:

TGZ0btrZLv Receipt - 2024-10-17.pdf

severinbeauvais commented 1 month ago

No, we cannot show the "Retrieve Business Information" button at this point (which redirects to the new business using its new ID) because the new business hasn't been created yet (so we don't have an ID).

It's probably not ideal that the Txxx number shows as part of the filename when the output is saved, but at least the number is unique (ie, not an issue if there were similar files in the save location). Also, I think it's OK to show these 2 outputs because it's a record of what the user has done up to this point.

Once the filing is completed -- and thus, the business has been created -- we do show the "Retrieve Business Information" button only (no outputs) to encourage the user to go to their new business' dashboard, where they can see all outputs and other allowed actions.

cc: @OlgaPotiagalova @Mihai-QuickSilverDev @janisrogers @jacqueline-williams-549

severinbeauvais commented 1 month ago

Blocked while awaiting a decision on what to do.

vikas-gov commented 1 month ago

Review with @OlgaPotiagalova for priority and next steps.

severinbeauvais commented 1 month ago

@Mihai-QuickSilverDev suggests leaving it like this.

Normally, a bootstrap filing is in this state temporarily. Once the filing is completed, the ledger item will not show documents, but the user can click a button to redirect to their new business' dashboard.

So, it's probably OK to keep it like this so that the user can at least access documents for what they've done, even if their name will contain the T number.

severinbeauvais commented 3 weeks ago

Deleted obsolete comment.

vikas-gov commented 3 weeks ago

Quick review results

Next Steps

janisrogers commented 2 weeks ago

Test Cases

https://docs.google.com/spreadsheets/d/1WCC66kPYQUzxbGn3x-th6zwnrT-J4el_l_MJ-VgaiwY/edit?usp=sharing

Receipt Filename Initially

Uses the T number except BC Numbered Immediate, ULC Continuation Named Immediate, and Amalgamation Named Immediate all of which showed no outputs until refresh, which then showed the final documents

Receipt Header (in blue text)

All that have receipts show the T number

Receipt filename after filing goes through (FEDs are still pending - I will update later)

All show the Incorporation or Registration number

Receipt Header after filing goes through (FEDs are still pending - I will update later)

All show the Company name

Incorporation Application filename initially

All with output show the T number

Incorporation Application header initially

All named show the Company Name, the Numbered show "Numbered Limited Company" except the ones that show no outputs

Incorporation Application filename after filing goes through

All show the Incorporation number

Incorporation Application Header after filing goes through

All show Company name or "Numbered Limited Company"

Some other anomalies

severinbeauvais commented 2 weeks ago

Thanks, Janis!

  • 4 test cases show the approved NR still on the dashboard after registration.

Yes, there are current environmental issues that could have caused this. However, although another application can use these NRs, it will not be possible to file these -- the Legal API (and possibly Filer) will check whether the NR is still active (and a real-time status query would return Consumed).

  • The Incorporation Effective Date and Recognition Date and Time fields for FED filings need to be reviewed. The text is missing or wrong.

Perhaps this is the same, or similar to, the bug reports in #23958. If so then can you please update that ticket with extra information?

Yes this bug covers it. I have updated it.

severinbeauvais commented 2 weeks ago

Receipt Filename Initially Uses the T number except BC Numbered Immediate, ULC Continuation Named Immediate, and Amalgamation Named Immediate all of which showed no outputs until refresh, which then showed the final documents

Are you saying that the "filed and pending" immediate, numbered continuation and amalgamation showed no outputs?

Should the other "filed and pending" filings also hide their outputs? What about the filed and pending FE filings?

janisrogers commented 2 weeks ago

I don't think the outputs should be hidden for any of the filings, but we are also not doing so consistently. For the IA, the Named FED and immediate and the Numbered FED show outputs, but the Numbered Immediate filing does not. The Named FED Continuation filing has outputs, but the Named Continuation immediate filing does not (I didn't try numbered),and the Named Amalgamation immediate filings does not show outputs, but I didn't try numbered or FED for amalgamation.

jacqueline-williams-549 commented 2 weeks ago

Arwen mentioned also while working on the continuation outputs that when the company doesn't have the identifier number BCxxx or Cxxxx, it has a temp identifier number and will show in the footer of the continuation applications. image.png

severinbeauvais commented 2 days ago

Note that the T number in the outputs (application + receipt) has been resolved by another ticket.

THIS ticket can now focus on: