bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Auth Web: show previous correspondence #22072

Closed severinbeauvais closed 3 weeks ago

severinbeauvais commented 1 month ago

This picks up where #21815 left off.

See Figma.

Figma: https://www.figma.com/design/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?node-id=560-2&t=8hiBRkJTyVRCI0fZ-0

severinbeauvais commented 1 month ago

Blocked by UI design (and business details/approvals).

severinbeauvais commented 1 month ago

I bumped up the estimate as we're still working through the API response (and the endpoint is not yet available).

severinbeauvais commented 1 month ago

Test Notes

The Continuation Authorization Review page is now driven by data from Legal API!

But:

The following reviews are populated and can be used for verification of this page:

severinbeauvais commented 1 month ago

Blocked while waiting for Relationships team to merge the (approved) PR.

severinbeauvais commented 1 month ago

Relationships team will not merge the PR until the code is transformed to Composition API and the date/time methods are changed to using Moment.

I've increased the estimate and moved this ticket back to In Progress accordingly.

janisrogers commented 4 weeks ago

This looks good and matches the design. I would change some of the words, but that could be a separate ticket. This is good to go to QA.

janisrogers commented 4 weeks ago

One strange note, is that the dates seem backwards. I assume this is just because of mocked data?

severinbeauvais commented 4 weeks ago

One strange note, is that the dates seem backwards. I assume this is just because of mocked data?

Hah, good catch. I just fixed the mock data in the database. Please have another look :)

janisrogers commented 4 weeks ago

Thanks @severinbeauvais that makes more sense.

NaveenHebbale commented 3 weeks ago

Working