search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Filings UI: Bootstrap filings are stuck in Filed and Pending state in test environment. #22139

Open riyazuddinsyed opened 4 months ago

riyazuddinsyed commented 4 months ago

Describe the bug in the current situation

When the user tries to file an IA/Firm Registrations/Continuation In Filings then after a successful payment the filings are stuck in a "Filed and PENDING state, needing a manual refresh for the "Retrieve Business" button to be visible.

Impact of this bug Users won't be able to see the "Retrieve Business" button

Steps to reproduce the behavior:

  1. Go to 'https://test.business.bcregistry.gov.bc.ca/'
  2. Start an IA or Firm Registration
  3. Complete the payment and observe that the filing stays in Filed and Pending State until a manual refresh.

Expected behavior Retrieve Business button should be visible after a successful filing.

Screenshots/ Visual Reference/ Source

Screen Shot 2024-07-03 at 3.02.09 PM.png
severinbeauvais commented 4 months ago

~This looks like the Filer did not receive the queue message from Business Pay (same as we've seen for several weeks in Dev).~

~I recommend asking @argush3 and @thorwolpert about this, in case there's a config or scaling issue in Test.~

~It may be possible to get these filings to go through by putting them back on the queue.~

see comments below

severinbeauvais commented 4 months ago

Riyaz, does this happen or can this ticket be closed now?

riyazuddinsyed commented 4 months ago

This happens Sev, and should be addressed.

severinbeauvais commented 4 months ago

@argush3 , @vysakh-menon-aot , can you have a quick look so we don't lose sight of this in bug triage?

vysakh-menon-aot commented 4 months ago

@severinbeauvais, @riyazuddinsyed says UI doesn't show "Retrieve Business" button until manual refresh.

severinbeauvais commented 4 months ago

Thanks, Vysakh, I missed that part.

So, the issue is that the filing isn't getting completed right away so the UI shows the intermediate state (pending). Upon refresh, the UI now shows the final state (completed).

This has always been an issue, because the Filer is async, though it may be worse today than initially. The filing blurb does say, "refresh this screen in a few minutes". An alternative would be to ensure the UI doesn't load the filing until it's completed -- but that could be indefinite. Another alternative would be for the UI to auto-retry, maybe once a second for 5 times, to see if the filing is now completed -- but the filing might still be incomplete for various reasons.

I think we need requirements from our BA, PO, etc.

vikas-gov commented 2 months ago

@mstanton1 As your team is working on this, Please review this scenario. For any questions please reach out to @Mihai-QuickSilverDev

severinbeauvais commented 2 months ago

This is a duplicate of #21041. I'll close that one.

mstanton1 commented 2 months ago

Thanks @vikas-gov. I'll review with my team / have them test in our dashboard once your fix is in. If the issue is in the filer we may not need separate work in our dashboard but I'll confirm.

severinbeauvais commented 2 months ago

Just to clarify...

I believe Entities-Olga's team is not working on this ticket. There is no Filer issue. The issue is that the business dashboard loads before the filing completes, so the user sees this "filed and pending" state.

Previously, most times, the Filer would complete the filing before the business dashboard loaded it, so the user would see the completed bootstrap filing, as desired.

Since we can't make the Filer faster, and it runs asynchronously anyway, one possible solution is for the business dashboard to poll (eg, every second for 5 seconds) in the background to see if the filing gets completed in that time. If so then the user is shown the completed filing; otherwise they see the "filed and pending" filing.

mstanton1 commented 2 months ago

Thanks for the clarity @severinbeauvais ! I'll add this to grooming, discuss with my team, and circle back in the next few weeks.

mstanton1 commented 2 months ago

@OlgaPotiagalova @severinbeauvais I've reviewed with my team. Our current scope is to build as is functionality, refactoring to improve usability where feasible. In this case, since it's functioning this way now, and is not a blocker to clients, our intention is to not pick this up.

We could close this for now, or update the ticket with an enhancement label to revisit at a later time? My preference is to close unless there have been client complains to support the need for this change. Are you okay with that?

severinbeauvais commented 2 months ago

I'm OK with closing this because of that last paragraph: "Refresh this screen in a few minutes.", which solves the issue.

image

However, I'd want to hear from @riyazuddinsyed and Olga before actually closing this ticket.

OlgaPotiagalova commented 2 months ago

Thank you @mstanton1. I suggest we add the enhancement label, rather than closing it, and return to it at a later time.

My position is that it might not be a blocker, but it is not a good user experience. Users expect real-time feedback, especially during critical operations like payments. We should be able to provide more seamless experience. There is information that users get confused and it generates unnecessary phone calls to BC Registries.

We will collect more data points to understand the scale of the problem. Linking to the Application Responsiveness epic for now.

mstanton1 commented 2 months ago

@OlgaPotiagalova sure. I see you've added the enhancement label. I'm going to remove BTR from this ticket given it's not in scope for our re-write of this page.