search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Phase 2 (RFC) - API: Create application endpoints #22343

Closed jdyck-fw closed 1 month ago

jdyck-fw commented 2 months ago
rstens commented 2 months ago
screencapture-localhost-8080-2024-07-30-09_40_45.png

Due to missing documentation in this ticket, it is unclear to me, if this indeed what it should be, or is there more to come?

I see the invoice, ltsa and auto-approval.

rstens commented 2 months ago

PostMan tests are very sparse - There are only simple requests in the collection. BTW we need to migrate to Bruno due to issues with Postman, see (#22514).

image.png

I can see that an LTSA and auto-approval tests are added, but they are very basic (just testing for code 200). We need to significantly expand on this in future iterations. For now, I would say I am missing the Invoice test.

rstens commented 2 months ago

There seems to be an LTSA (Registrations) end point. In the UI this fails:

image.png
kris-daxiom commented 2 months ago

PostMan tests are very sparse - There are only simple requests in the collection. BTW we need to migrate to Bruno due to issues with Postman, see (#22514). image.png

I can see that an LTSA and auto-approval tests are added, but they are very basic (just testing for code 200). We need to significantly expand on this in future iterations. For now, I would say I am missing the Invoice test.

FYI, AutoApproval will be triggered as a background job and unless you have a test data set up that is run before the postman tests are executed, there is no way this will return any data. Another reason is payment has to be through first which we normally dont test via postman tests.So I dont see how these tests will change in the future unless you run the script to set up all this data manually before testing

kris-daxiom commented 2 months ago
screencapture-localhost-8080-2024-07-30-09_40_45.png

Due to missing documentation in this ticket, it is unclear to me, if this indeed what it should be, or is there more to come?

I see the invoice, ltsa and auto-approval.

You will test this as part of the test script you are writing. Invoice endpoint will be removed as part of RFC and the relevant data will be in the application response. I dont see any reason why the invoice endpoint should be there

rstens commented 2 months ago

@kris-daxiom So you are saying, once I have the e2e tests this will be inherently tested? If you have an invoice related end-point in your API: Are you saying we should not have a test for that?

kris-daxiom commented 2 months ago

@kris-daxiom So you are saying, once I have the e2e tests this will be inherently tested?

100%

rstens commented 2 months ago

As per discussion during Scrum, we are moving this ticket forward for now. The consensus is that during upcoming E2E testing the new API functionality will be able to be addressed properly.

I have established that:

What wasn't tested: