bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Emailer: continuation in email templates - implement #22363

Closed vikas-gov closed 1 week ago

vikas-gov commented 1 month ago

See also #22290.

UI Designs: Design ticket: https://app.zenhub.com/workspaces/design-team-space-new-655bd9f095d1aa3852dd86af/issues/gh/bcgov/entity/22223 Figma: https://www.figma.com/board/q8xFNQ1kAPQ3RGXXJaAlQw/Continuation-Application-Workflow?node-id=0-1&t=xusYCCkdiHpsfopf-0 Figma: https://www.figma.com/design/Tl8uDClgM5NAozzMltfiMD/Entities-Emails?node-id=2556-14&t=Lj14aw7p8ptjsXPF-0 Templates: https://docs.google.com/spreadsheets/d/17wMY9znmWMr2RoXH9S2elffC8uE7iifUGB5Hu3VVFpE/edit?gid=0#gid=0

To Do:

These emails need to include the email body text from the staff review.

See also #21820 (email triggers).

severinbeauvais commented 4 weeks ago

I've assigned this ticket to myself so that I can review the changes with @janisrogers (and also for #22290).

severinbeauvais commented 3 weeks ago

@janisrogers We need to discuss the updated application templates (eg, with "- Pending" or "- Rejected" title). I believe we never show the application when it's in Pending state (eg, draft, awaiting staff review, change requested or resubmitted); we only show the application when it's Approved (and waiting for Filer, could be future effective) or Rejected or Completed.

cc: @vysakh-menon-aot

severinbeauvais commented 3 weeks ago

@ketaki-deodhar @vysakh-menon-aot Can you provide some hints for implementing "consume the new email events", please and thanks!

vysakh-menon-aot commented 3 weeks ago

nothing to be done for this. you will receive this event here https://github.com/bcgov/lear/blob/main/queue_services/entity-emailer/src/entity_emailer/worker.py#L211

severinbeauvais commented 3 weeks ago

@Mihai-QuickSilverDev @andyyanggov Do you think we need to send the user a "RESUBMITTED" email with the updated application attached?

(It would be sent when the user clicks "Resubmit" after updating the filing after a change was requested by staff.)

Mihai-QuickSilverDev commented 2 weeks ago

Yes, it makes sense. Hopefully is just a repeat of the process (similar to the original submission).

vikas-gov commented 2 weeks ago

Agreement is to complete and commit this ticket (rgd: FED Decision pending)