Create UI: implement more resubmission changes

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 58 forks source link

Create UI: implement more resubmission changes #22549

Closed severinbeauvais closed 3 weeks ago

severinbeauvais commented 1 month ago

This ticket continues #21824.

This ticket depends on having the latest UI designs.

[x] update Continuation Authorization layout per latest UI designs
[x] change immediate radio button label to "Immediately upon approval"
[x] change future effective radio button label to "A date / time in the future (subject to approval)"
[x] make Continuation Authorization section invalid until user makes a change there

Figma: https://www.figma.com/design/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?node-id=2911-11052&t=Ujx806ozZBapm4zC-0

severinbeauvais commented 1 month ago

Screenshots

Continuation Authorization layout update:

Incorporation Date and Time radio buttons for all filings except Continuation In:

Incorporation Date and Time radio buttons for Continuation In filings:

severinbeauvais commented 1 month ago

Test Notes

Sample continuation application in Draft status: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TB2Xip34mj

Sample continuation application in Change Requested status: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=T1nUSllvEt

@andyyanggov I enabled validation right away if the current filing (eg, continuation application) is in Change Requested status. Normally, a user has to go to the review page to enable this, and then they see any errors. In this case, enabling validation right away makes sense to me because the application should be all valid except the continuation authorization files section, so their attention is brought to that. Let me know if you disagree. Links above if you want to try it.

andyyanggov commented 1 month ago

@severinbeauvais Let's make the alert font size 14px regular (non-italic) to match other alerts (like the yellow one higher up the page). Otherwise, looks good to me.

severinbeauvais commented 1 month ago

I will submit the changes we talked about shortly. In the meantime, enjoy these screenshots.

Can I move this to RFQA after the changes are merged and deployed to Dev?

Single-line example:

Multi-line example:

severinbeauvais commented 1 month ago

The above change is now deployed to Dev.

NaveenHebbale commented 3 weeks ago

Implemented