search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Not able to accept the invite while trying to join the team #2260

Closed ghost closed 4 years ago

ghost commented 4 years ago

Describe the Bug When a user tries to accept the invite of the sender(Owner/Admin) to join the team, there is an error page displayed

Preconditions Owner sends invite to the user to join the team User is not the part of any other team 1 Owner, 1 Admin, 1 member already exists in the team

Steps to Reproduce

  1. When the owner sends the invite to the user to join the team, the user opens the email and click on join team button
  2. Enter the login credentials to join the team

Actual Output An error screen is displayed Clipboard - January 6, 2020 1_43 PM.png

Expected Output User is allowed to join and the screen output should be displayed Screen Shot 2020-01-06 at 1.51.03 PM.png

@saravankumarpa

lmullane commented 4 years ago

@saravan were you able to reproduce?

saravankumarpa commented 4 years ago

@saravan were you able to reproduce?

Patrick and I were actively spending time on this. This happens only intermittently ;so hard to figure out whats going on wrong. I will sit with Nithin tomorrow and get to the bottom of this.

saravankumarpa commented 4 years ago

@lmullane I got it. Fixing now

sutherlanda commented 4 years ago

Can we a bit more info on the conditions needed to reproduce this bug prior to pushing the fix for it?

The fix looks like the bug only occurred if there was more than one owner/admin on the team, but we should document that in the ticket. It would also save time during troubleshooting if these tickets could include additional info (for example, a screenshot showing the state of the team involved would have provided a great clue).

saravankumarpa commented 4 years ago

Hm... U r right.. The behaviour was Nithin,simply on accepting the invitation , gets an error page. After checking the logs , a 400 BAD request was shown in the logs while sending the admin notification. Patrick and I was on it and we couldnt reproduce much.Even for nithin , it wasn't consistent. But after digging into this , I think it happens when there are multiple admins in the team and sending the mail to multiple admins fails. This was the consistent way of reproducing it.

saravankumarpa commented 4 years ago

@nitin-freshworks Plz add more documentation regarding this behaviour so that ticket can be referred back later

ghost commented 4 years ago

@sutherlanda @saravankumarpa I will add more details in the ticket..

ghost commented 4 years ago

Tested in test env and works fine. Moving it to done.