search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Continuation In - Unexpected Duplication when Replacing File #22612

Open andyyanggov opened 1 month ago

andyyanggov commented 1 month ago

Clicking on the file uploader to replace a file will duplicate the new file. Here's a short demo of the bug.

Continuation In - Unexpected Duplication when Replacing Uploaded File.png
severinbeauvais commented 1 month ago

This may be a root file uploader issue but we might be able to work around it in the continuation in application (as in screenshot above).

severinbeauvais commented 1 month ago

Note: despite the Continuation Authorization section showing the file twice...

image.png

... the Review and Confirm page shows different data in memory...

image.png
severinbeauvais commented 1 month ago

Sample continuation application to play with: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TB2Xip34mj

severinbeauvais commented 2 weeks ago

I believe the issue is with the logic to add a file. It mistakenly "adds" a copy of the file instead of "replaces" it, at least as far as the UI components is concerned (since the data in memory seems to be OK).

severinbeauvais commented 1 week ago

Consider doing #22995 instead of THIS bug.