bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Jurisdiction outside NWPTA is shown in EP paragraph in stage 1 email #22657

Closed chenhongjing closed 3 weeks ago

chenhongjing commented 1 month ago

Jurisdictions outside NWPTA(AB, BC, MB, and SK) can be shown in extraprovincial information paragraph in stage 1 email. And the names of foreign jurisdictions(>2) are only connected by "and" instead of commas.

Steps to Reproduce

  1. find/create a business which has extraprovincial registrations outside NWPTA.
  2. move this business into stage 1 of dissolution
  3. run furnishings job for stage 1 dissolution
  4. check the email notification for this business
  5. all extraprovicial jurisdictions are shown in the email and all are connected by "and" (Note that the wording and information shown in the attachment are correct)

Screenshots In this incorrect example, we should not show Quebec even though the business has registered in it. The correct wording is "Alberta, Manitoba, and Saskatchewan".

image.png
JazzarKarim commented 3 weeks ago

Test Notes:

I think you can follow the steps to reproduce up top in the ticket.

vishnup0422 commented 3 weeks ago

Created a new BC business BC0883563 Picked an EP business BC0048578 which has jurisdictions in AB,MN,SK

Screenshot 2024-08-28 at 2.08.58 PM.png

Updated the BC business with this BC0048578 in LEAR and Auth DB's.

Made the business eligible for dissolution and moved to stage 1.

Screenshot 2024-08-28 at 2.12.21 PM.png Screenshot 2024-08-28 at 2.21.50 PM.png

Ran the Furnishings job. The paragraph is updated

Screenshot 2024-08-28 at 2.23.13 PM.png