bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Filings UI: allow external routing to local filings #22822

Closed severinbeauvais closed 2 months ago

severinbeauvais commented 3 months ago

As per #21469, a new Dashboard UI will be created and will serve as the launching and return point for all filings, including the "local filings" currently done in Filings UI (and which will stay in Filings UI).

In this ticket, externally routing to the following filings needs to work.

  1. load necessary tombstone data (App.vue. TodoList.vue, etc)
  2. update local routes to use "query" instead of "params" objects
  3. update filings to read id from route query parameter

The affected filings are:

~It is unknown whether a Feature Flag needs to be used to support both the old and new functionality (for cutover purposes).~ No FF is needed. The local filings will be compatible with the current Filings UI and the new, external entity dashboard.

See also #21574.

severinbeauvais commented 3 months ago

Thinking about this quickly, I believe this won't be a ton of work and won't even need a feature flag, so I've reduced the estimate.

severinbeauvais commented 3 months ago

Test Notes

Please verify that all local filings start correctly (including resuming a draft where applicable):

  1. AGM Extension
  2. AGM Location Change
  3. ~Amalgamation Out~ not enabled so cannot be tested
  4. Annual Report (both corp and coop)
  5. ~Consent for Amalgamation Out~ not enabled so cannot be tested
  6. Consent for Continuation Out
  7. Continuation Out
  8. Standalone Directors Filing (aka Change of Directors)
  9. Standalone Office Address Filing (aka Change of Addresses)

Please verify direct access to the following filings, either as new drafts (id=0) or resuming an existing draft (eg, id=123):

  1. AGM Extension: https://dev.business.bcregistry.gov.bc.ca/BC0874938/agm-extension?filingId=0
  2. AGM Location Change: https://dev.business.bcregistry.gov.bc.ca/BC0874938/agm-location-chg?filingId=0
  3. ~Amalgamation Out:~ not enabled so cannot be tested
  4. Annual Report (both corp and coop): https://dev.business.bcregistry.gov.bc.ca/BC0871417/annual-report?filingId=0&arFilingYear=2024 https://dev.business.bcregistry.gov.bc.ca/CP1002485/annual-report?filingId=0&arFilingYear=2024
  5. ~Consent for Amalgamation Out:~ not enabled so cannot be tested
  6. Consent for Continuation Out: https://dev.business.bcregistry.gov.bc.ca/BC0874938/consent-continuation-out?filingId=0
  7. Continuation Out: https://dev.business.bcregistry.gov.bc.ca/BC0874938/continuation-out?filingId=0
  8. Standalone Directors Filing (aka Change of Directors): https://dev.business.bcregistry.gov.bc.ca/BC0874938/standalone-directors?filingId=0
  9. Standalone Office Address Filing (aka Change of Addresses): https://dev.business.bcregistry.gov.bc.ca/BC0874938/standalone-addresses?filingId=0 .
  10. Resuming a coop draft: https://dev.business.bcregistry.gov.bc.ca/CP1002485/annual-report?filingId=150762&arFilingYear=2024
severinbeauvais commented 3 months ago

@kialj876 FYI, this is now deployed to Dev.