Create UI: resolution or court order dates should be carried across in an amalgamation

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 58 forks source link

Create UI: resolution or court order dates should be carried across in an amalgamation #22846

Closed severinbeauvais closed 5 days ago

severinbeauvais commented 2 months ago

In #20893, two BENs were amalgamated into a new Benefit Company. The bug is that a resolution date (pertaining to the share structure) from the primary TING was not carried over to the new TED.

[x] should we carry over all resolution dates? - yes
[x] for regular amalgamations, should we allow entry of resolution dates? no, same as creating a new IA
[x] fetch resolutions for holding/primary business, ie:
[x] show resolution dates on review page along with share structure, ie:
[ ] save in draft + resume from draft as needed

See also #23054 (back end ticket).

severinbeauvais commented 1 month ago

deleted obsolete comment

severinbeauvais commented 1 month ago

To do:

[x] fetch resolutions (same flow as fetching share structure, parties, etc)
[x] show resolution dates on summary page (see sample screenshots above)
[x] save resolution dates in filing (and restore if needed -- see existing code for share structure, etc)

severinbeauvais commented 2 weeks ago

The PR for this work has been merged. UX peeps, please have a quick look and pass along to QA if satisfactory. (I think Ketaki already checked with you on styling. You can also check the PR for screenshots.)

jacqueline-williams-549 commented 2 weeks ago

I did review with Ketaki and the styling for this looks great. I had some concerns about the language, but was unable to get it reviewed/approved today.

jacqueline-williams-549 commented 1 week ago

I would like to simplify the language used here

Original statement

Dates of resolution or court orders to alter the company's share structure or the special rights or restrictions to a class or a series of shares.

Would like to change to this

Dates of resolution or court orders to change the company's share structure. This includes dates for adjusting the special rights or restrictions on a specific class or series of shares.

@ketaki-deodhar This language has been approved

janisrogers commented 1 week ago

I don't know that your statement conveys the same information. Let's discuss.

ketaki-deodhar commented 1 week ago

@jacqueline-williams-549 I will update it soon

jacqueline-williams-549 commented 1 week ago

Thanks @ketaki-deodhar this looks great.