bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

API - Correct Statuses throughout application (related to new statuses) #22936

Closed mbertucci closed 3 weeks ago

mbertucci commented 2 months ago

https://bcgov.sharepoint.com/:x:/r/teams/09399/Shared%20Documents/Product-Scrum%20Team%20Chat/Field%20validation%20and%20Status%20Table.xlsx?d=wd73427566b6148b48776b7c8682de8e9&csf=1&web=1&e=djD5qC&nav=MTVfezRGMDRERDMwLUFGRUQtNDE4Ri1CQUU3LTkxQjc0ODI2RTU4RH0

mbertucci commented 2 months ago

we need to have versioning on the excel table so we we now what has changed since the last time we reviewed it.

mbertucci commented 1 month ago

We two API tickets related to updating statuses

22831 - API - update actions in application · bcgov/entity (zenhub.com)

22396 API - Correct Statuses throughout application · bcgov/entity (zenhub.com)

and one UI ticket #22397

dimak1 commented 1 month ago

@rstens because we didn't want to break the app, this was not merged to main, but rather into a separate branch. So this is not deployed to Dev env. I will continue to work on UI changes (on this separate branch) and then merge to main and promote to Dev.

Is this ok with you, can we proceed without testing this specific ticket yet?

jdyck-fw commented 1 month ago

Waiting for the UI ticket

qudsia-khan-fw commented 1 month ago

22832 will be merged with this as one

kris-daxiom commented 1 month ago

API changes are deployed to DEV. Postman tests can be used to QA this if needed or it can be QA'd once UI changes are available.

rstens commented 4 weeks ago

I'll revisit once the UI is there. I reviewed the code and that looks straightforward. No other observation (for now).

rstens commented 4 weeks ago

Mind you , the UI might seem broken (because it is not aligned with te new changes) and you'll see statuses like this:

Application Status

Status

applicationDetails.FULL_REVIEW_APPROVED
dimak1 commented 4 weeks ago

@rstens I'm working on updating UI with the new statuses.

shaangill025 commented 4 weeks ago

@dimak1 https://github.com/bcgov/STRR/pull/160 will include the UI changes for this.

rstens commented 4 weeks ago

@dimak1 , @shaangill025 All good

kris-daxiom commented 4 weeks ago

@roland we promoted all changes just before this PR to test. So everythingelse before this should be there in test